Optimization #4318
open
app-layer: "close" all txs if protocol reaches error state
Added by Shivani Bhardwaj about 3 years ago.
Updated over 1 year ago.
Description
Currently, in case there was a mis-detection of protocol or something led to incomplete data error in a protocol parser, the cleanup is not done properly.
Victor says "we should have logic that "closes" all txs (marks them as done), or handle this in the lower layers"
This came up when DCE/RPC over UDP packet was misdetected as Wireguard protocol and took too much of processing power.
- Subject changed from Logic that "closes" all txs to app-layer: "close" all txs if protocol reaches error state
- Assignee changed from Victor Julien to Philippe Antoine
- Status changed from Assigned to In Review
When an error is returned by an app-layer parser over UDP, nothing happens (the return value of AppLayerHandleUdp is ignored)
There is no equivalent of STREAMTCP_FLAG_APP_LAYER_DISABLED
Should we do something ?
- Priority changed from Normal to Low
- Effort set to high
- Difficulty set to high
- Target version changed from 7.0.0-beta1 to TBD
- Status changed from In Review to Assigned
- Assignee changed from Philippe Antoine to OISF Dev
Not sure what the best way to deal with this is, and this seems high effort and low priority to get it right...
Also available in: Atom
PDF