Project

General

Profile

Bug #4358

Add warning/error for datatypes differing b/w C and Rust w FFI

Added by Shivani Bhardwaj 4 months ago. Updated 15 days ago.

Status:
Assigned
Priority:
Low
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

PR https://github.com/OISF/suricata/pull/5903/checks?check_run_id=1960895136 failed tests on Windows because of a type mismatch (u8 <-> i32), there was no warning/error from the compiler or cbindgen about this. Add a warning for such cases.
Jason says, "The compiler or cbindgen can't warn us here, but we could look at bindgen to create the extern statements.. However, not sure if it will define these function types for it, it generates more traditional extern statements like https://github.com/OISF/suricata/blob/681f95e80a885e56493b0994b22539b0bfbfa8a5/rust/src/core.rs#L224"


Related issues

Related to Bug #4516: Integer overflowsAssignedJeff LucovskyActions
#1

Updated by Shivani Bhardwaj 15 days ago

  • Related to Bug #4516: Integer overflows added
#2

Updated by Shivani Bhardwaj 15 days ago

  • Priority changed from Normal to Low

Also available in: Atom PDF