Project

General

Profile

Actions

Task #4682

open
VJ JI

Task #2693: tracking: libsuricata

tracking: clean up globals and thread locals

Task #4682: tracking: clean up globals and thread locals

Added by Victor Julien over 4 years ago. Updated 5 months ago.

Status:
Assigned
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:

Description

As we want to turn Suricata into libsuricata where there could be multiple instances of the suricata code in the consuming app, the suricata code can't rely on any globals or thread local vars.

While thread locals work in the context of the Suricata application, as a library, where users are bringing their own threads, it's possible that multiple, but distinct instances of the Suricata engine are run on the same thread. In this case, using thread locals can leak state from one instance into another. The thread pool is a good example here, as each instance may have its own pool settings and pre-allocated packet sizes.


Subtasks 4 (3 open1 closed)

Task #4683: detect: remove sigmatch_table in favor of a dynamic storage optionClosedPhilippe AntoineActions
Task #4684: libsuricata: define global context types for instance and per thread storageNewJason IshActions
Task #8078: threading: don't use thread local for packet poolAssignedOISF DevActions
Task #8106: misc: don't use global for SCInstanceIn ProgressJason IshActions

Related issues 1 (1 open0 closed)

Blocks Suricata - Story #8098: 9.0.0: libsuricataAssignedVictor JulienActions

PA Updated by Philippe Antoine almost 2 years ago Actions #1

  • Assignee set to Jason Ish
  • Target version set to TBD

JI Updated by Jason Ish 6 months ago Actions #2

  • Status changed from New to Assigned
  • Target version changed from TBD to 9.0.0-beta1

JI Updated by Jason Ish 5 months ago Actions #3

  • Subtask #8078 added

JI Updated by Jason Ish 5 months ago Actions #4

  • Description updated (diff)

JI Updated by Jason Ish 5 months ago Actions #5

JI Updated by Jason Ish 5 months ago Actions #6

  • Subtask #8106 added
Actions

Also available in: PDF Atom