Project

General

Profile

Actions

Task #4714

closed

Improve unittests coverage for Suricata's application layers rust nom parsers

Added by Juliana Fajardini Reichow about 1 year ago. Updated 3 days ago.

Status:
Rejected
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:
Beginner, Outreachy, Rust

Description

Some of the Suricata app-layer parsers require better unittests coverage. For this ticket, the focus are the nom parsers, well-suited for test-driven development, as they can run as standalone units.

If you want to contribute with this ticket, please comment below which unassigned file you want to claim/work with. We'll keep track of available files like so, in this ticket.

The idea is to cover the most important/complex parsers. Some of the files listed already have some coverage but would be benefited if one tested a few more of the key nom parsers (or those which are not laterally tested by being called by other parsers). The files tagged needs tests don't have any unittests at all, as of now.

If you believe any file doesn't require more unit tests, please tell us so, explaining why, so we can mark them as covered.

File Current state Assigned
ike::parser needs tests unassigned
nfs::nfs2_records needs tests Sam Muhammed
nfs::nfs3_records needs tests Sam Muhammed
nfs::nfs4_records needs tests Sam Muhammed
smb::ntlmssp_records needs tests unassigned
smb::dcerpc_records needs tests unassigned
smb::smb1_records needs tests unassigned
smb::smb2_records needs tests unassigned
sip::parser some key parsers aren't covered unassigned
smb::smb3 some key parsers aren't covered unassigned
dhcp::parser maybe a test for parse_all_options unassigned
mqtt::parser test key parsers Haleema Khan
rfb::parser needs more tests Haleema Khan

Related issues 1 (1 open0 closed)

Related to Task #4864: Increase coverage of unit tests across SuricataNewCommunity TicketActions
Actions #1

Updated by Juliana Fajardini Reichow about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Shivani Bhardwaj about 1 year ago

  • Related to Task #4864: Increase coverage of unit tests across Suricata added
Actions #3

Updated by Sam Muhammed 12 months ago

I'd like to claim the `nfs*_records` files, please.

Actions #4

Updated by Juliana Fajardini Reichow 12 months ago

  • Description updated (diff)

Ok, marking those as assigned to you, Sam!

Actions #5

Updated by Juliana Fajardini Reichow 4 days ago

  • Description updated (diff)
Actions #6

Updated by Juliana Fajardini Reichow 4 days ago

  • Description updated (diff)
Actions #7

Updated by Victor Julien 3 days ago

On further thought, I prefer actual subtickets instead of this table acting as a list of pseudo tickets.

Actions #8

Updated by Juliana Fajardini Reichow 3 days ago

  • Status changed from New to Rejected

We have this: https://redmine.openinfosecfoundation.org/issues/4864

I shall close this one, then.

Actions

Also available in: Atom PDF