Task #4866
closedTask #4864: Increase coverage of unit tests across Suricata
rust/nfs/*: add unit tests
Description
Add tests for all the logical units and parsers.
Example: https://github.com/OISF/suricata/blob/master/rust/src/sip/parser.rs#L242
Test should be made with data from real network traffic.
Suggested pcap sources to look for such traffic: https://forum.suricata.io/t/sharing-good-sources-of-sample-captures/1766
Testing guide:
https://github.com/OISF/suricata/blob/master/doc/devguide/codebase/testing.rst
https://github.com/OISF/suricata/blob/master/doc/devguide/codebase/unittests-rust.rst
https://github.com/OISF/suricata/blob/master/doc/devguide/codebase/unittests-c.rst
JF Updated by Juliana Fajardini Reichow about 4 years ago
- Assignee set to Sam Mohammad
Sam has already been working on this, but that was only mentioned here: https://redmine.openinfosecfoundation.org/issues/4714
SM Updated by Sam Mohammad about 4 years ago
- Status changed from New to In Progress
SM Updated by Sam Mohammad about 4 years ago
- Status changed from In Progress to Closed
PR Merged nfs2:
https://github.com/OISF/suricata/pull/6779/commits/86c273dadc973326f20782195e4d63de272f1f91
PR Merged nfs3:
https://github.com/OISF/suricata/pull/6779/commits/4e2edd44aa08f08286001701ec0860c6638625d5
PR Merged nfs4:
https://github.com/OISF/suricata/pull/6779/commits/9bea850d53b3336de3868ce43e3416c53afe772c
https://github.com/OISF/suricata/pull/6819/commits/c4bd3cd70e3b0a2718eb404a214748780cfc4db4
VJ Updated by Victor Julien over 3 years ago
- Target version set to 7.0.0-beta1