Project

General

Profile

Actions

Bug #5316

closed

smtp: PreProcessCommands does not handle all the edge cases

Added by Shivani Bhardwaj over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Issue
An edge case where <CRLF> came in fragmented for a line was not handled. This resulted in <CR> being treated as regular data byte and not as a part of the line end sequence. This particularly led to issues when base64 encoded data was processed by MIME and it could not handle the <CR> char as it relied on only receiving correct data from SMTP parser making file sizes different and inconsistent.

Context
As per RFC 2821 (SMTP),
a. Bare `CR` and `LF` have a long history of problems w mail implementations and applications.
b. An ideal SMTP client MUST NOT transmit `CR` and `LF` chars except when they are intended as line terminators and then also as `<CRLF>` sequence ONLY.
c. We should tolerate trailing `SP` before the terminating `<CRLF>`


Subtasks 2 (0 open2 closed)

Bug #5338: smtp: PreProcessCommands does not handle all the edge cases (6.0.x backport)ClosedVictor JulienActions
Bug #5339: PreProcessCommands does not handle all the edge cases (5.0.x backport)ClosedVictor JulienActions
Actions #1

Updated by Shivani Bhardwaj over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Jeff Lucovsky over 2 years ago

  • Copied to Bug #5338: smtp: PreProcessCommands does not handle all the edge cases (6.0.x backport) added
Actions #3

Updated by Jeff Lucovsky over 2 years ago

  • Copied to Bug #5339: PreProcessCommands does not handle all the edge cases (5.0.x backport) added
Actions #4

Updated by Shivani Bhardwaj over 2 years ago

  • Status changed from Assigned to In Review
Actions #5

Updated by Victor Julien over 2 years ago

  • Status changed from In Review to Closed
Actions #6

Updated by Victor Julien over 2 years ago

  • Label deleted (Needs backport to 5.0, Needs backport to 6.0)
Actions #7

Updated by Victor Julien about 2 years ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF