Project

General

Profile

Actions

Bug #5338

closed

Bug #5316: smtp: PreProcessCommands does not handle all the edge cases

smtp: PreProcessCommands does not handle all the edge cases (6.0.x backport)

Added by Jeff Lucovsky almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

Issue
An edge case where <CRLF> came in fragmented for a line was not handled. This resulted in <CR> being treated as regular data byte and not as a part of the line end sequence. This particularly led to issues when base64 encoded data was processed by MIME and it could not handle the <CR> char as it relied on only receiving correct data from SMTP parser making file sizes different and inconsistent.

Context
As per RFC 2821 (SMTP),
a. Bare `CR` and `LF` have a long history of problems w mail implementations and applications.
b. An ideal SMTP client MUST NOT transmit `CR` and `LF` chars except when they are intended as line terminators and then also as `<CRLF>` sequence ONLY.
c. We should tolerate trailing `SP` before the terminating `<CRLF>`

Actions #1

Updated by Jeff Lucovsky almost 2 years ago

  • Copied from Bug #5316: smtp: PreProcessCommands does not handle all the edge cases added
Actions #2

Updated by Jeff Lucovsky almost 2 years ago

  • Subject changed from smtp: PreProcessCommands does not handle all the edge cases to Backport 6.0.x: smtp: PreProcessCommands does not handle all the edge cases
  • Parent task set to #5316
Actions #3

Updated by Jeff Lucovsky almost 2 years ago

  • Subject changed from Backport 6.0.x: smtp: PreProcessCommands does not handle all the edge cases to smtp: PreProcessCommands does not handle all the edge cases (6.0.x backport)
Actions #4

Updated by Victor Julien over 1 year ago

  • Status changed from Assigned to In Progress
  • Assignee changed from Shivani Bhardwaj to Victor Julien
Actions #5

Updated by Victor Julien over 1 year ago

  • Status changed from In Progress to In Review
Actions #6

Updated by Victor Julien over 1 year ago

  • Status changed from In Review to Closed
Actions #7

Updated by Victor Julien about 1 year ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF