Project

General

Profile

Actions

Bug #6490

open

profiling: rule profiling doesn't support absolute paths

Added by Corey Thomas 9 months ago. Updated 14 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

While testing rule profiling I noticed that a filename-path of /dev/null will get appended to the log directory and end up complaining about the file not being found (like /some/path//dev/null).

profiling:
  # Run profiling for every X-th packet. The default is 1, which means we
  # profile every packet. If set to 1000, one packet is profiled for every
  # 1000 received.
  #sample-rate: 1000

  # rule profiling
  rules:

    # Profiling can be disabled here, but it will still have a
    # performance impact if compiled in.
    enabled: yes
    filename: profile.json # < this as /dev/null

Would expect the full path to be used so you can place files outside of your log directory (or log but dump in the case of /dev/null)


Subtasks 1 (1 open0 closed)

Bug #7166: profiling: rule profiling doesn't support absolute paths (7.0.x backport)AssignedVictor JulienActions
Actions #1

Updated by Victor Julien 17 days ago

  • Status changed from New to In Progress
  • Assignee changed from OISF Dev to Victor Julien
  • Priority changed from Low to Normal
  • Target version changed from TBD to 8.0.0-beta1
Actions #2

Updated by Victor Julien 17 days ago

  • Subject changed from Rule profiling log appends path to log directory to profiling: rule profiling doesn't support absolute paths
  • Status changed from In Progress to In Review
Actions #3

Updated by Corey Thomas 16 days ago ยท Edited

This still seems to be failing in the PR. I'm not sure where PathIsAbsolute is defined but it must not be getting the /

Error: profiling-rules: failed to open /...../var/log/suricata///dev/null: No such file or directory [SCProfilingRuleDump:util-profiling-rules.c:415]

Actions #4

Updated by Victor Julien 14 days ago

  • Status changed from In Review to Resolved
  • Label Needs backport to 7.0 added
Actions #5

Updated by OISF Ticketbot 14 days ago

  • Subtask #7166 added
Actions #6

Updated by OISF Ticketbot 14 days ago

  • Label deleted (Needs backport to 7.0)
Actions

Also available in: Atom PDF