Project

General

Profile

Actions
Copy link

Bug #6891

closed
PA PA

sip: usage of Vec instead of Vecdeque leads to quadratic complexity on cleanup

Bug #6891: sip: usage of Vec instead of Vecdeque leads to quadratic complexity on cleanup

Added by Philippe Antoine about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Philippe Antoine
Target version:
8.0.0-beta1
Affected Versions:
git main
Effort:
Difficulty:
Label:

Description

Found by oss-fuzz with quadfuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=67597

I would rate this CRITICAL, but I am not sure it affects suricata 7 as the oss-fuzz bisect points to the addition of TCP for sip parsing...

PA Updated by Philippe Antoine about 2 years ago Actions
Copy link
 #1

  • Subject changed from sip: unbounded number of transaction lead to quadratic complexity to sip: usage of Vic instead of Vecdeque leads to quadratic complexity on cleanup
  • Affected Versions git main added

Indeed only for SIP/TCP as SIP/UDP parses only one transaction per packet, and it is considered as complete

PA Updated by Philippe Antoine about 2 years ago Actions
Copy link
 #2

  • Subject changed from sip: usage of Vic instead of Vecdeque leads to quadratic complexity on cleanup to sip: usage of Vec instead of Vecdeque leads to quadratic complexity on cleanup

PA Updated by Philippe Antoine about 2 years ago Actions
Copy link
 #3

  • Status changed from New to In Review

Gitlab MR

PA Updated by Philippe Antoine about 2 years ago Actions
Copy link
 #4

  • Status changed from In Review to Closed

VJ Updated by Victor Julien almost 2 years ago Actions
Copy link
 #5

  • Tracker changed from Security to Bug
  • Severity deleted (MODERATE)
  • Disclosure Date deleted (06/24/2024)

Set to bug as it's not part of released code.

VJ Updated by Victor Julien almost 2 years ago Actions
Copy link
 #6

  • Private changed from Yes to No
Actions
Copy link

Also available in: PDF Atom