Project

General

Profile

Actions

Security #7040

closed

defrag: id reuse can lead to invalid reassembly

Added by Victor Julien about 1 year ago. Updated 2 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Label:
Git IDs:
Severity:
CRITICAL
Disclosure Date:

Description

When 2 sets of fragments are sent with the same id in quick succession, the 2nd set may reuse the DefragTracker for the first set. This will lead to incorrect reassembly logic. An incomplete packet will be decoded, leading to decoder events and general policy bypass.

The issue is in DefragGetTrackerFromHash which does not respect the DefragTracker::remove field in all it's lookup paths.


Subtasks 2 (0 open2 closed)

Security #7041: defrag: id reuse can lead to invalid reassembly (6.0.x backport)ClosedVictor JulienActions
Security #7042: defrag: id reuse can lead to invalid reassembly (7.0.x backport)ClosedVictor JulienActions
Actions #1

Updated by OISF Ticketbot about 1 year ago

  • Subtask #7041 added
Actions #2

Updated by OISF Ticketbot about 1 year ago

  • Label deleted (Needs backport to 6.0)
Actions #3

Updated by OISF Ticketbot about 1 year ago

  • Subtask #7042 added
Actions #4

Updated by OISF Ticketbot about 1 year ago

  • Label deleted (Needs backport to 7.0)
Actions #5

Updated by Victor Julien about 1 year ago

  • Status changed from In Progress to In Review

Issue is addressed as part of a refactoring here https://github.com/OISF/suricata/pull/11122

Actions #6

Updated by Victor Julien about 1 year ago

  • Severity changed from MODERATE to CRITICAL
Actions #7

Updated by Victor Julien about 1 year ago

  • Status changed from In Review to Resolved

Fixed as part of the general cleanups in:

https://github.com/OISF/suricata/pull/11227

Actions #9

Updated by Victor Julien about 1 year ago

  • CVE set to 2024-37151
Actions #10

Updated by Victor Julien about 1 year ago

  • Status changed from Resolved to Closed
Actions #11

Updated by Juliana Fajardini Reichow 2 days ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF