Optimization #7044
closedapplayer: clean up truncate callbacks and logic
Description
Original :
It seems that when moving dcerpc to Rust (https://github.com/OISF/suricata/commit/bac69af7e4082d4829cd9aad5bdfd0b0d35070b9),
the callback/reference to rs_dcerpc_state_trunc ended up being missed (was here https://github.com/OISF/suricata/commit/8b2886635f2d69e302499971a1a0fde8b2099a50#diff-88368b0c2f03a908440ab63346e55e7561cc93233e0a5c0156959e122a783cbaR186)
Final : It was concluded that the entire truncate routine and callbacks were unneeded and this ended up being a cleanup instead of a bug.
Updated by Shivani Bhardwaj 7 months ago
- Status changed from New to Assigned
- Assignee changed from OISF Dev to Shivani Bhardwaj
Updated by Shivani Bhardwaj 7 months ago
In Review PR: https://github.com/OISF/suricata/pull/11151
Thanks for the detailed analysis, @Juliana Fajardini Reichow :)
Updated by Shivani Bhardwaj 7 months ago
- Status changed from Assigned to In Review
Updated by Juliana Fajardini Reichow 7 months ago
Shivani Bhardwaj wrote in #note-5:
In Review PR: https://github.com/OISF/suricata/pull/11151
Thanks for the detailed analysis, @Juliana Fajardini Reichow :)
No problems! Just wanted to make sure what I was reporting made sense xP
Updated by Shivani Bhardwaj 6 months ago
- Tracker changed from Bug to Optimization
- Subject changed from dcerpc: missing call to truncate function to applayer: clean up truncate callbacks and logic
- Description updated (diff)
- Affected Versions deleted (
7.0.5, git master)
Updated by Shivani Bhardwaj 5 months ago
- Status changed from In Review to Resolved
Closed by: https://github.com/OISF/suricata/pull/11436
Updated by Shivani Bhardwaj about 1 month ago
- Status changed from Resolved to Closed