Project

General

Profile

Actions
Copy link

Optimization #7044

closed
JF SB

app-layer: clean up truncate callbacks and logic

Optimization #7044: app-layer: clean up truncate callbacks and logic

Added by Juliana Fajardini Reichow almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Shivani Bhardwaj
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:

Description

Original :
It seems that when moving dcerpc to Rust (https://github.com/OISF/suricata/commit/bac69af7e4082d4829cd9aad5bdfd0b0d35070b9),
the callback/reference to rs_dcerpc_state_trunc ended up being missed (was here https://github.com/OISF/suricata/commit/8b2886635f2d69e302499971a1a0fde8b2099a50#diff-88368b0c2f03a908440ab63346e55e7561cc93233e0a5c0156959e122a783cbaR186)

Final : It was concluded that the entire truncate routine and callbacks were unneeded and this ended up being a cleanup instead of a bug.

Subtasks 1 (0 open — 1 closed)

Optimization #7046: applayer: clean up truncate callbacks and logic (7.0.x backport)RejectedShivani BhardwajActions

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #1

  • Status changed from New to Assigned
  • Assignee changed from OISF Dev to Shivani Bhardwaj

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #2

  • Label Needs backport to 7.0 added

OT Updated by OISF Ticketbot almost 2 years ago Actions
Copy link
 #3

  • Subtask #7046 added

OT Updated by OISF Ticketbot almost 2 years ago Actions
Copy link
 #4

  • Label deleted (Needs backport to 7.0)

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #5

In Review PR: https://github.com/OISF/suricata/pull/11151

Thanks for the detailed analysis, @Juliana Fajardini Reichow :)

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #6

  • Status changed from Assigned to In Review

JF Updated by Juliana Fajardini Reichow almost 2 years ago Actions
Copy link
 #7

Shivani Bhardwaj wrote in #note-5:

In Review PR: https://github.com/OISF/suricata/pull/11151

Thanks for the detailed analysis, @Juliana Fajardini Reichow :)

No problems! Just wanted to make sure what I was reporting made sense xP

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #8

  • Description updated (diff)

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #9

  • Tracker changed from Bug to Optimization
  • Subject changed from dcerpc: missing call to truncate function to applayer: clean up truncate callbacks and logic
  • Description updated (diff)
  • Affected Versions deleted (7.0.5, git main)

SB Updated by Shivani Bhardwaj almost 2 years ago Actions
Copy link
 #10

  • Status changed from In Review to Resolved

SB Updated by Shivani Bhardwaj over 1 year ago Actions
Copy link
 #11

  • Status changed from Resolved to Closed

VJ Updated by Victor Julien about 1 year ago Actions
Copy link
 #12

  • Subject changed from applayer: clean up truncate callbacks and logic to app-layer: clean up truncate callbacks and logic
Actions
Copy link

Also available in: PDF Atom