Project

General

Profile

Actions

Bug #7115

closed
LS LS

dpdk: timestamping packets through TSC does not yield the same time as kernel time

Bug #7115: dpdk: timestamping packets through TSC does not yield the same time as kernel time

Added by Lukas Sismis almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

According to https://forum.suricata.io/t/suricata-ahead-of-time/4716/9 timestamping packets through TSC counter can be a bit off from the kernel time. Originally implemented to have better precision and faster timestamping, it seems like it can shift a little from the kernel time.
Therefore I'd suggest to replace it with the standard kernel call (gettimeoftheday or SCGetTime) to get the timestamp.


Subtasks 1 (0 open1 closed)

Bug #7116: dpdk: timestamping packets through TSC does not yield the same time as kernel time (7.0.x backport)ClosedLukas SismisActions

Related issues 1 (0 open1 closed)

Related to Suricata - Optimization #7585: af-packet: SOF_TIMESTAMPING_RAW_HARDWARE dangerous default leading to incorrect timestampsClosedVictor JulienActions

OT Updated by OISF Ticketbot almost 2 years ago Actions #1

  • Subtask #7116 added

OT Updated by OISF Ticketbot almost 2 years ago Actions #2

  • Label deleted (Needs backport to 7.0)

VJ Updated by Victor Julien almost 2 years ago Actions #3

Do we understand why these can differ?

LS Updated by Lukas Sismis almost 2 years ago Actions #4

  • Status changed from Assigned to Resolved

explanation in the commit message - TSC counter can drift over a long time,
merged in https://github.com/OISF/suricata/pull/11409

LS Updated by Lukas Sismis over 1 year ago Actions #5

  • Status changed from Resolved to Closed

VJ Updated by Victor Julien about 1 year ago Actions #6

  • Related to Optimization #7585: af-packet: SOF_TIMESTAMPING_RAW_HARDWARE dangerous default leading to incorrect timestamps added
Actions

Also available in: PDF Atom