Project

General

Profile

Actions
Copy link

Optimization #7212

closed
JL FZ

strtoul: replace with ByteExtractString variant

Optimization #7212: strtoul: replace with ByteExtractString variant

Added by Jeff Lucovsky over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Fupeng Zhao
Target version:
8.0.0
Effort:
low
Difficulty:
Label:
Beginner, Good First Issue

Description

The library utility strtoul has been factored into Suricata's ByteExtractString routines. Determining when strtoul is a bit awkward, so we should standardize on using ByteExtractString* and create suricata-verify tests wherever it's replaced.

JF Updated by Juliana Fajardini Reichow over 1 year ago Actions
Copy link
 #1

  • Assignee changed from OISF Dev to Community Ticket

PA Updated by Philippe Antoine about 1 year ago Actions
Copy link
 #2

  • Tracker changed from Bug to Optimization

FZ Updated by Fupeng Zhao 10 months ago Actions
Copy link
 #3

  • Assignee changed from Community Ticket to Fupeng Zhao

Hi,

I’d like to start contributing to Suricata, and this issue looks like a great entry point for me. So I’ve assigned the issue to myself.

Please feel free to let me know if there are any additional pointers or prior discussions I should review before diving in.

Thanks!

FZ Updated by Fupeng Zhao 10 months ago Actions
Copy link
 #4

  • Status changed from New to In Progress

FZ Updated by Fupeng Zhao 10 months ago Actions
Copy link
 #5

  • Status changed from In Progress to In Review

SB Updated by Shivani Bhardwaj 10 months ago Actions
Copy link
 #7

  • Target version changed from TBD to 8.0.0
  • Label deleted (Needs Suricata-Verify test, Outreachy)

FZ Updated by Fupeng Zhao 10 months ago Actions
Copy link
 #8

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: PDF Atom