Project

General

Profile

Actions
Copy link

Optimization #7212

closed

strtoul: replace with ByteExtractString variant

Added by Jeff Lucovsky 12 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Fupeng Zhao
Target version:
8.0.0
Effort:
low
Difficulty:
Label:
Beginner, Good First Issue

Description

The library utility strtoul has been factored into Suricata's ByteExtractString routines. Determining when strtoul is a bit awkward, so we should standardize on using ByteExtractString* and create suricata-verify tests wherever it's replaced.

Actions
Copy link
 #1

Updated by Juliana Fajardini Reichow 10 months ago

  • Assignee changed from OISF Dev to Community Ticket
Actions
Copy link
 #2

Updated by Philippe Antoine 5 months ago

  • Tracker changed from Bug to Optimization
Actions
Copy link
 #3

Updated by Fupeng Zhao about 2 months ago

  • Assignee changed from Community Ticket to Fupeng Zhao

Hi,

I’d like to start contributing to Suricata, and this issue looks like a great entry point for me. So I’ve assigned the issue to myself.

Please feel free to let me know if there are any additional pointers or prior discussions I should review before diving in.

Thanks!

Actions
Copy link
 #4

Updated by Fupeng Zhao about 2 months ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Fupeng Zhao about 2 months ago

  • Status changed from In Progress to In Review
Actions
Copy link
 #7

Updated by Shivani Bhardwaj about 2 months ago

  • Target version changed from TBD to 8.0.0
  • Label deleted (Needs Suricata-Verify test, Outreachy)
Actions
Copy link
 #8

Updated by Fupeng Zhao about 1 month ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF