Bug #7226: lua: use crate from crates.io instead of github to fix offline builds - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #7226

closed

lua: use crate from crates.io instead of github to fix offline builds

Added by Jason Ish 4 months ago. Updated about 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Jason Ish

Target version:

8.0.0-beta1

Affected Versions:

git master

Effort:

Difficulty:

Label:

Description

For offline builds to work with the vendored Rust crates, they must be from crates.io.

Actions

Copy link

Updated by Jason Ish 3 months ago

When we vendor Rust crates, the following .cargo/config.toml is created:

[source]

[source.crates-io]
registry = 'https://github.com/rust-lang/crates.io-index'
replace-with = 'vendored-sources'

[source.vendored-sources]
directory = '/home/jason/oisf/dev/suricata/master/rust/vendor'

This will tell Cargo to look for "crates.io" hosted crates in our local directory. When we git as a source for a crate it does not apply, and we'd need an entry just for that repo. So keep things simple, once we are ready to merge to master we should probably push to crates.io.

Actions

Copy link