Project

General

Profile

Actions

Bug #7226

closed

lua: use crate from crates.io instead of github to fix offline builds

Added by Jason Ish 3 months ago. Updated 29 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

For offline builds to work with the vendored Rust crates, they must be from crates.io.

Actions #1

Updated by Jason Ish 2 months ago

When we vendor Rust crates, the following .cargo/config.toml is created:

[source]

[source.crates-io]
registry = 'https://github.com/rust-lang/crates.io-index'
replace-with = 'vendored-sources'

[source.vendored-sources]
directory = '/home/jason/oisf/dev/suricata/master/rust/vendor'

This will tell Cargo to look for "crates.io" hosted crates in our local directory. When we git as a source for a crate it does not apply, and we'd need an entry just for that repo. So keep things simple, once we are ready to merge to master we should probably push to crates.io.

Actions #3

Updated by Jason Ish 29 days ago

  • Status changed from In Review to Closed

Merged.

Actions

Also available in: Atom PDF