Optimization #7353
closedfiles: remove deprecated force-md5 config option
Added by Philippe Antoine over 1 year ago. Updated 11 months ago.
Description
in util-file.c
VJ Updated by Victor Julien about 1 year ago Actions #1
- Subject changed from Remove deprecated force-md5 config option to files: remove deprecated force-md5 config option
- Target version changed from 8.0.0-beta1 to TBD
This is something we'd only do if we remove md5 tracking, matching and logging.
JI Updated by Jason Ish about 1 year ago Actions #2
I'm curious what is the reason to deprecate md5? Besides not being cryptographically secure, it still seems to be in wide use for identifying files.
PA Updated by Philippe Antoine about 1 year ago Actions #3
SCLogWarning("deprecated 'force-md5' option "
"found. Please use 'force-hash: [md5]' instead");
PA Updated by Philippe Antoine about 1 year ago Actions #4
Victor Julien wrote in #note-1:
This is something we'd only do if we remove md5 tracking, matching and logging.
No, we do md5 tracking, matching and logging with force-hash: [md5] instead of force-md5 in suricata.yaml
Do not we want to have this for 8 ?
PA Updated by Philippe Antoine about 1 year ago Actions #5
git grep deprecated shows other stuff like legacy.uricontent ...
JI Updated by Jason Ish about 1 year ago Actions #6
Philippe Antoine wrote in #note-4:
Victor Julien wrote in #note-1:
This is something we'd only do if we remove md5 tracking, matching and logging.
No, we do md5 tracking, matching and logging with
force-hash: [md5]instead offorce-md5in suricata.yamlDo not we want to have this for 8 ?
I think this makes sense then. The ticket didn't have enough context to reason about it properly.
PA Updated by Philippe Antoine about 1 year ago Actions #7
- Target version changed from TBD to 8.0.0-beta1
VJ Updated by Victor Julien about 1 year ago Actions #8
- Target version changed from 8.0.0-beta1 to 8.0.0-rc1
PA Updated by Philippe Antoine 11 months ago Actions #9
- Status changed from New to In Review
- Assignee changed from OISF Dev to Philippe Antoine
PA Updated by Philippe Antoine 11 months ago Actions #10
- Status changed from In Review to Closed