Bug #8184: Loop counters underflows across codebase - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #8184

open

Loop counters underflows across codebase

Added by Sergey Zhidkih about 1 month ago. Updated 19 days ago.

Status:

In Review

Priority:

Normal

Assignee:

Sergey Zhidkih

Target version:

9.0.0-beta1

Affected Versions:

6.0.13, 7.0.0, 6.0.14, 7.0.1, 6.0.15, 7.0.2, 6.0.16, 7.0.3, 6.0.17, 7.0.4, 6.0.18, 6.0.19, 7.0.5, 6.0.20, 7.0.6, 7.0.7, 7.0.8, 7.0.9, 7.0.10, 8.0.0-beta1, 8.0.0-rc1, 7.0.11, 8.0.0, 7.0.12, 8.0.1, 7.0.13, 8.0.2, 7.0.14, 8.0.3, 7.0.15, 8.0.4, 9.0.0-beta1, 9.0.0

Effort:

Difficulty:

low

Label:

Description

During the fuzzing of sigpcap for 7.10.0, multiple occurrences of loop counter underflow were detected.

After investigation, it was determined that the issue affected 11 source code files.

Most of the loops contained underflow after the counter was fully used, which had almost no impact on the application's operation. Some of the loops were written in a very strange manner, with unnecessary checks that made it a bit difficult to understand. One loop seemed to actually cause a minor bug.

So I fixed all of them.

Files

Download all files

00113df1431c20d709afc5df9d12beb8e4236fb5 (52.6 KB) 00113df1431c20d709afc5df9d12beb8e4236fb5		Sergey Zhidkih, 12/29/2025 12:23 PM
00113df1431c20d709afc5df9d12beb8e4236fb5.log (108 KB) 00113df1431c20d709afc5df9d12beb8e4236fb5.log		Sergey Zhidkih, 12/29/2025 12:23 PM

Actions

Copy link

Updated by Victor Julien 29 days ago

Hi Sergey, you mention that "So I fixed all of them". Where did you fix this?

Actions

Copy link

Updated by Sergey Zhidkih 29 days ago

Victor Julien wrote in #note-1:

Hi Sergey, you mention that "So I fixed all of them". Where did you fix this?

I haven't created a pull request for review yet since I'm on vacation right now. I will create a PR closer to the end of the week or, most likely, next week.

Actions

Copy link