Project

General

Profile

Actions

Feature #8459

open
VJ JF

firewall: support bypass option with firewall rules

Feature #8459: firewall: support bypass option with firewall rules

Added by Victor Julien 4 months ago. Updated 11 days ago.

Status:
In Progress
Priority:
High
Target version:
Effort:
Difficulty:
Label:

Description

Also test what happens to firewall rules with bypass in a TD rule.


Related issues 2 (1 open1 closed)

Related to Suricata - Task #8551: firewall: ban usage of "replace" keywordClosedJuliana Fajardini ReichowActions
Related to Suricata - Feature #8781: firewall: allow bypass as a default policyNewJuliana Fajardini ReichowActions

JF Updated by Juliana Fajardini Reichow 3 months ago Actions #1

  • Status changed from New to Assigned
  • Assignee set to Juliana Fajardini Reichow
  • Target version changed from TBD to 9.0.0-beta1

JF Updated by Juliana Fajardini Reichow 3 months ago Actions #2

  • Related to Task #8551: firewall: ban usage of "replace" keyword added

JF Updated by Juliana Fajardini Reichow 3 months ago Actions #3

For now, we think it's safer to ban the usage of bypass keyword in firewall mode.

JF Updated by Juliana Fajardini Reichow 29 days ago Actions #4

Probably something like: accept:flow,bypass, for firewall rules, only.

The ban would still persist for the keyword for threat detection/ ids rules, in firewall mode, though.

JI Updated by Jason Ish 28 days ago Actions #5

  • Priority changed from Normal to High

JF Updated by Juliana Fajardini Reichow 23 days ago Actions #6

  • Status changed from Assigned to In Progress

JF Updated by Juliana Fajardini Reichow 15 days ago Actions #7

JF Updated by Juliana Fajardini Reichow 15 days ago Actions #8

In summary, what we have discussed is that the bypass keyword probably shouldn't be valid with most combinations of action and scope, as well as in threat detection rules, in firewall mode.

There are some corner cases to still be tested and ensure we're applying the bypass at the correct time. Automated review indicates that in the case of a single packet flow with a Threat detection drop, we may not get the expected behavior, if we that packet also triggers a `bypass` firewall rule, due to when the engine(s) processes and applies the firewall rules and local bypass action.

JF Updated by Juliana Fajardini Reichow 11 days ago Actions #9

  • Related to Feature #8781: firewall: allow bypass as a default policy added

JF Updated by Juliana Fajardini Reichow 11 days ago Actions #10

Add to current work:
- if bypass is local, pre-flow rules will still be processed and invoked.
- SV test for the above

Follow-ups:
- Special hook pre-flow:
- ban bypass + SV test(s)
- Special hook pre-stream:
- allow bypass + SV test

JF Updated by Juliana Fajardini Reichow 11 days ago Actions #11

TBD whether we would want to allow drop:flow + bypass at some point, but we might.

Actions

Also available in: PDF Atom