Project

General

Profile

Actions
Copy link

Optimization #945

open
VJ PA

remove useless includes

Optimization #945: remove useless includes

Added by Victor Julien about 13 years ago. Updated 29 days ago.

Status:
In Progress
Priority:
Low
Assignee:
Philippe Antoine
Target version:
TBD
Effort:
Difficulty:
Label:

Description

This may be useful to us:
http://sylvestre.ledru.info/blog/2013/09/08/include-what-you-use-yet

However, we should test on all our supported architectures before we do remove things.

VJ Updated by Victor Julien over 7 years ago Actions
Copy link
 #1

  • Assignee changed from OISF Dev to Community Ticket

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #2

Maybe codeql/lgtm.com can find these unneeded includes

PA Updated by Philippe Antoine over 4 years ago Actions
Copy link
 #3

  • Status changed from New to In Review
  • Assignee changed from Community Ticket to Philippe Antoine

PA Updated by Philippe Antoine about 4 years ago Actions
Copy link
 #4

  • Target version changed from TBD to 7.0.0-beta1

PA Updated by Philippe Antoine about 4 years ago Actions
Copy link
 #5

With the merge of https://github.com/OISF/suricata/pull/7644
we now have that done for header files

It is still to do for C files

PA Updated by Philippe Antoine about 4 years ago Actions
Copy link
 #6

  • Priority changed from Normal to Low

VJ Updated by Victor Julien almost 4 years ago Actions
Copy link
 #7

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1

PA Updated by Philippe Antoine almost 4 years ago Actions
Copy link
 #8

  • Assignee changed from Philippe Antoine to OISF Dev
  • Target version changed from 7.0.0-rc1 to TBD

To check back in a few years

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
 #9

  • Assignee changed from OISF Dev to Philippe Antoine

Is this complete?

PA Updated by Philippe Antoine over 3 years ago Actions
Copy link
 #10

Still to reset CI workflow up and fix new unnecessary includes

PA Updated by Philippe Antoine 6 months ago Actions
Copy link
 #12

  • Status changed from In Review to In Progress

PA Updated by Philippe Antoine 5 months ago Actions
Copy link
 #13

Rustifying has more priority for now...

PA Updated by Philippe Antoine 29 days ago Actions
Copy link
 #14

Playing a bit with AI

  1. AI advises me to use include-what-you-use
  2. iwyu on app-layer-htp-range.c
    app-layer-htp-range.c should remove these lines:
- #include "rust.h"  // lines 25-25
- #include "util-memcmp.h"  // lines 29-29
  3. Without rust.h the code does not compile anymore
  4. app-layer-htp-range.c needs "util-memcmp.h" for SCBufferCmp but util-memcmp.h is in suricata-common.h

PA Updated by Philippe Antoine 29 days ago Actions
Copy link
 #15

Should tm-threads-common.h continue to live in suricata-common.h ? (and so, we should remove its other inclusions)

Actions
Copy link

Also available in: PDF Atom