Actions
Optimization #945
open
VJ
PA
remove useless includes
Optimization #945:
remove useless includes
Added by Victor Julien about 13 years ago. Updated 29 days ago.
Effort:
Difficulty:
Label:
Description
This may be useful to us:
http://sylvestre.ledru.info/blog/2013/09/08/include-what-you-use-yet
However, we should test on all our supported architectures before we do remove things.
VJ Updated by Victor Julien over 7 years ago Actions #1
- Assignee changed from OISF Dev to Community Ticket
PA Updated by Philippe Antoine over 5 years ago Actions #2
Maybe codeql/lgtm.com can find these unneeded includes
PA Updated by Philippe Antoine over 4 years ago Actions #3
- Status changed from New to In Review
- Assignee changed from Community Ticket to Philippe Antoine
PA Updated by Philippe Antoine about 4 years ago Actions #4
- Target version changed from TBD to 7.0.0-beta1
PA Updated by Philippe Antoine about 4 years ago Actions #5
With the merge of https://github.com/OISF/suricata/pull/7644
we now have that done for header files
It is still to do for C files
PA Updated by Philippe Antoine about 4 years ago Actions #6
- Priority changed from Normal to Low
VJ Updated by Victor Julien almost 4 years ago Actions #7
- Target version changed from 7.0.0-beta1 to 7.0.0-rc1
PA Updated by Philippe Antoine almost 4 years ago Actions #8
- Assignee changed from Philippe Antoine to OISF Dev
- Target version changed from 7.0.0-rc1 to TBD
To check back in a few years
VJ Updated by Victor Julien over 3 years ago Actions #9
- Assignee changed from OISF Dev to Philippe Antoine
Is this complete?
PA Updated by Philippe Antoine over 3 years ago Actions #10
Still to reset CI workflow up and fix new unnecessary includes
PA Updated by Philippe Antoine almost 2 years ago Actions #11
PA Updated by Philippe Antoine 6 months ago Actions #12
- Status changed from In Review to In Progress
PA Updated by Philippe Antoine 5 months ago Actions #13
Rustifying has more priority for now...
PA Updated by Philippe Antoine 29 days ago Actions #14
Playing a bit with AI
- AI advises me to use include-what-you-use
- iwyu on app-layer-htp-range.c
app-layer-htp-range.c should remove these lines: - #include "rust.h" // lines 25-25 - #include "util-memcmp.h" // lines 29-29
- Without rust.h the code does not compile anymore
- app-layer-htp-range.c needs "util-memcmp.h" for SCBufferCmp but util-memcmp.h is in suricata-common.h
PA Updated by Philippe Antoine 29 days ago Actions #15
Should tm-threads-common.h continue to live in suricata-common.h ? (and so, we should remove its other inclusions)
PA Updated by Philippe Antoine 29 days ago Actions #16
Actions