Project

General

Profile

Actions
Copy link

Optimization #945

open

remove useless includes

Added by Victor Julien about 11 years ago. Updated 25 days ago.

Status:
In Review
Priority:
Low
Assignee:
Philippe Antoine
Target version:
TBD
Effort:
Difficulty:
Label:

Description

This may be useful to us:
http://sylvestre.ledru.info/blog/2013/09/08/include-what-you-use-yet

However, we should test on all our supported architectures before we do remove things.

Actions
Copy link
 #1

Updated by Victor Julien over 5 years ago

  • Assignee changed from OISF Dev to Community Ticket
Actions
Copy link
 #2

Updated by Philippe Antoine over 3 years ago

Maybe codeql/lgtm.com can find these unneeded includes

Actions
Copy link
 #3

Updated by Philippe Antoine over 2 years ago

  • Status changed from New to In Review
  • Assignee changed from Community Ticket to Philippe Antoine
Actions
Copy link
 #4

Updated by Philippe Antoine over 2 years ago

  • Target version changed from TBD to 7.0.0-beta1
Actions
Copy link
 #5

Updated by Philippe Antoine over 2 years ago

With the merge of https://github.com/OISF/suricata/pull/7644
we now have that done for header files

It is still to do for C files

Actions
Copy link
 #6

Updated by Philippe Antoine about 2 years ago

  • Priority changed from Normal to Low
Actions
Copy link
 #7

Updated by Victor Julien about 2 years ago

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1
Actions
Copy link
 #8

Updated by Philippe Antoine about 2 years ago

  • Assignee changed from Philippe Antoine to OISF Dev
  • Target version changed from 7.0.0-rc1 to TBD

To check back in a few years

Actions
Copy link
 #9

Updated by Victor Julien over 1 year ago

  • Assignee changed from OISF Dev to Philippe Antoine

Is this complete?

Actions
Copy link
 #10

Updated by Philippe Antoine over 1 year ago

Still to reset CI workflow up and fix new unnecessary includes

Actions
Copy link

Also available in: Atom PDF