Project

General

Profile

Actions

Optimization #1218

closed

BoyerMooreNocase could avoid tolower() call

Added by Ken Steele over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

The function BoyerMooreNoCase() uses tolower() to convert each character to lower case before looking it up in the jump tables. It would be simpler to just duplicate the lowercase jump values into the uppercase jump entries and remove the tolower() calls.

This requires that the tables for case and nocase of the same content string are not shared. This might already be the case.

Actions #1

Updated by Ken Steele over 10 years ago

It appears that case and nocase do not share a context.

Actions #2

Updated by Victor Julien over 10 years ago

Each instance of a content keyword has it's own bm ctx, which is then either case sensitive or case in-sensitive.

Actions #3

Updated by Andreas Herz almost 9 years ago

  • Assignee set to OISF Dev
  • Target version set to TBD
Actions #4

Updated by Philippe Antoine over 5 years ago

  • Assignee changed from OISF Dev to Philippe Antoine
Actions #5

Updated by Philippe Antoine over 5 years ago

  • Status changed from New to Closed
  • Target version changed from TBD to 5.0rc1
Actions

Also available in: Atom PDF