Project

General

Profile

Actions
Copy link

Bug #126

closed

Radix tree implementation leaks memory

Added by Victor Julien about 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Pablo Rincon
Target version:
0.8.2
Affected Versions:
Effort:
Difficulty:
Label:

Description

The radix tree implementation leaks memory in several places. This causes the current ip-only matching code to fill up the memory. When running a large pcap the memory usage grows to 6GB+ easily (at this point I killed the process).

The issue seems to be that in SCRadixFindKey an object "prefix" is created, but it's not freed at all in cases where the function returns NULL and possibly never ever. The same issue seems to be present in SCRadixAddKey and SCRadixRemoveKey at least.

Please completely review the radix implementation.

Files

Download all files
0004-Release-the-tmp-prefix-used-for-searching-on-the-rad.patch (2.23 KB) 0004-Release-the-tmp-prefix-used-for-searching-on-the-rad.patch the fix Pablo Rincon, 04/12/2010 08:13 AM
0005-Unittest-used-to-check-the-radix-memleak-located-at-.patch (2.11 KB) 0005-Unittest-used-to-check-the-radix-memleak-located-at-.patch a unittest that should increase the memory dramatically if the search have memleaks Pablo Rincon, 04/12/2010 08:13 AM
0006-Register-the-free-function-for-nodes-of-the-radix-tr.patch (4.71 KB) 0006-Register-the-free-function-for-nodes-of-the-radix-tr.patch fix the current unittests registering a free() function when the trees are created Pablo Rincon, 04/12/2010 08:13 AM
Actions
Copy link

Also available in: Atom PDF