Project

General

Profile

Actions
Copy link

Task #2879

closed
JI VG

Log a warning on duplicate SID.

Task #2879: Log a warning on duplicate SID.

Added by Jason Ish about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vagisha Gupta
Target version:
1.1.0rc1
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

Currently when suricata-update encounters a rules with duplicate SIDs, it will silently use the one with the higher revision. While I believe this behaviour is correct, we should still log a warning.

On duplicate SID we should probably log the following as warnings:
- If revisions differ: Found duplicate rule ID %d, keeping one with higher revision.
- If revisions are equals: Found duplicate rule ID %s, keeping existing rule.

SB Updated by Shivani Bhardwaj about 7 years ago Actions
Copy link
 #1

  • Assignee deleted (Shivani Bhardwaj)

SB Updated by Shivani Bhardwaj about 7 years ago Actions
Copy link
 #2

  • Status changed from New to Assigned

AH Updated by Andreas Herz almost 7 years ago Actions
Copy link
 #3

  • Assignee set to OISF Dev

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #5

  • Status changed from Assigned to Feedback

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #6

  • Assignee changed from OISF Dev to Vagisha Gupta

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #7

  • Status changed from Feedback to Resolved

SB Updated by Shivani Bhardwaj over 6 years ago Actions
Copy link
 #8

  • Status changed from Resolved to Closed

JI Updated by Jason Ish over 6 years ago Actions
Copy link
 #9

  • Target version set to TBD

JI Updated by Jason Ish over 6 years ago Actions
Copy link
 #10

  • Target version changed from TBD to 1.1.0rc1
Actions
Copy link

Also available in: PDF Atom