Project

General

Profile

Actions
Copy link

Task #2879

closed

Log a warning on duplicate SID.

Added by Jason Ish over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vagisha Gupta
Target version:
1.1.0rc1
Effort:
low
Difficulty:
low
Label:
Beginner, Outreachy

Description

Currently when suricata-update encounters a rules with duplicate SIDs, it will silently use the one with the higher revision. While I believe this behaviour is correct, we should still log a warning.

On duplicate SID we should probably log the following as warnings:
- If revisions differ: Found duplicate rule ID %d, keeping one with higher revision.
- If revisions are equals: Found duplicate rule ID %s, keeping existing rule.

Actions
Copy link
 #1

Updated by Shivani Bhardwaj over 5 years ago

  • Assignee deleted (Shivani Bhardwaj)
Actions
Copy link
 #2

Updated by Shivani Bhardwaj over 5 years ago

  • Status changed from New to Assigned
Actions
Copy link
 #3

Updated by Andreas Herz over 5 years ago

  • Assignee set to OISF Dev
Actions
Copy link
 #5

Updated by Shivani Bhardwaj over 5 years ago

  • Status changed from Assigned to Feedback
Actions
Copy link
 #6

Updated by Shivani Bhardwaj over 5 years ago

  • Assignee changed from OISF Dev to Vagisha Gupta
Actions
Copy link
 #7

Updated by Shivani Bhardwaj over 5 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #8

Updated by Shivani Bhardwaj over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #9

Updated by Jason Ish over 5 years ago

  • Target version set to TBD
Actions
Copy link
 #10

Updated by Jason Ish about 5 years ago

  • Target version changed from TBD to 1.1.0rc1
Actions
Copy link

Also available in: Atom PDF