Project

General

Profile

Actions
Copy link

Optimization #2911

closed

Error thrown on re-enabling existing sources

Added by Marcin Kubica about 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Shivani Bhardwaj
Target version:
1.0.5
Effort:
Difficulty:
Label:

Description

Hi. New user here and really liking Suricata so far.

Re-enabling existing sources should raise info, aprox. warning.
Setting this to error and throwing non-zero exit code is not feasible and requires any automation to
ignore it, and might lead to missing real problems.

It also looks ugly ;)

suricata: TASK [suricata : Enable suricata sources] ******************************
    suricata: Friday 29 March 2019  16:45:05 +0000 (0:00:01.539)       0:00:27.844 ****
    suricata: changed: [suricata] => (item=ptresearch/attackdetection)
    suricata: failed: [suricata] (item=et/open) => {
    suricata:     "changed": true,
    suricata:     "cmd": "/usr/bin/suricata-update enable-source et/open",
    suricata:     "delta": "0:00:00.218601",
    suricata:     "end": "2019-03-29 16:45:06.580351",
    suricata:     "item": "et/open",
    suricata:     "rc": 1,
    suricata:     "start": "2019-03-29 16:45:06.361750" 
    suricata: }
    suricata:
    suricata: STDERR:
    suricata:
    suricata: 2019-03-29 16:45:06,542 - <INFO> - Using data-directory /var/lib/suricata.
    suricata: 2019-03-29 16:45:06,543 - <INFO> - Using Suricata configuration /etc/suricata/suricata.yaml
    suricata: 2019-03-29 16:45:06,543 - <INFO> - Using /etc/suricata/rules for Suricata provided rules.
    suricata: 2019-03-29 16:45:06,556 - <INFO> - Found Suricata version 4.1.2 at /usr/bin/suricata.
    suricata: 2019-03-29 16:45:06,556 - <ERROR> - The source et/open is already enabled.
    suricata:
    suricata:
    suricata: MSG:
    suricata:
    suricata: non-zero return code
    suricata: changed: [suricata] => (item=sslbl/ssl-fp-blacklist)
    suricata: changed: [suricata] => (item=etnetera/aggressive)
    suricata: ...ignoring
    suricata:

Best!
Marcin

Actions
Copy link
 #1

Updated by Shivani Bhardwaj about 5 years ago

  • Status changed from New to Feedback
  • Target version set to 1.0.5

There is already a PR for this: https://github.com/OISF/suricata-update/pull/93 We're trying to get this in the next release. Hopefully, this would be solved for you with the release of 1.0.5.

Actions
Copy link
 #2

Updated by Jason Ish almost 5 years ago

  • Status changed from Feedback to Rejected
Actions
Copy link

Also available in: Atom PDF