Project

General

Profile

Actions

Optimization #2728

closed

enable repeated calls of enable/disable-source

Added by Sascha Steinbiss over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
low
Label:

Description

At the moment, trying to enable a source that is already enabled will result in suricata-update failing with a return code of 1 and the error message:

2018-12-04 17:15:14,285 - <ERROR> - The source oisf/trafficid is already enabled.

This is problematic, for example, when using Ansible to set up and maintain an environment where configuration of various sources is necessary. The idea is to be able to repeatedly apply the role without running into an error (and without having to explicitly check whether a source is enabled or disabled). I would be happy submit a patch that tackles this, e.g. by making this a warning only and not returning a nonzero return code.

Actions #1

Updated by Victor Julien over 5 years ago

  • Project changed from Suricata to Suricata-Update
  • Subject changed from suricata-update: enable repeated calls of enable/disable-source to enable repeated calls of enable/disable-source
Actions #2

Updated by Shivani Bhardwaj about 5 years ago

  • Status changed from New to Feedback
  • Target version set to TBD
  • Effort deleted (low)
Actions #3

Updated by Jason Ish almost 5 years ago

  • Status changed from Feedback to Closed
  • Target version changed from TBD to 1.0.5
Actions

Also available in: Atom PDF