Project

General

Profile

Actions

Bug #3097

open

build for eBPF programs needs a way to specify Linux header location

Added by Hilko Bengen almost 6 years ago. Updated about 7 hours ago.

Status:
Feedback
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

We saw that building eBPF programs on Debian unstable does not work reliably because the include path is specified as /usr/include/$(build_cpu)-$(build_os). Instead, /usr/include/<multiarch-triplet> should be used, but there's no easy, portable way to determine that.

https://buildd.debian.org/status/fetch.php?pkg=suricata&arch=i386&ver=1%3A4.1.4-3&stamp=1563813999&raw=0

Actions #1

Updated by Hilko Bengen almost 6 years ago

I have a patch ready, but a fix for #2789 should be merged first.

Actions #2

Updated by Andreas Herz almost 6 years ago

  • Assignee set to Hilko Bengen
  • Target version set to TBD
Actions #3

Updated by Andreas Herz almost 6 years ago

Since it's now merged, will you send us the patch :)?

Actions #4

Updated by Victor Julien almost 6 years ago

  • Status changed from New to Assigned
  • Target version changed from TBD to 70
Actions #5

Updated by Victor Julien almost 5 years ago

  • Target version changed from 70 to TBD
Actions #6

Updated by Philippe Antoine 2 days ago

  • Status changed from Assigned to Feedback

Is this still an issue nowadays ? (Suri 8 till uses /usr/include/$(build_cpu)-$(build_os). )

Actions #7

Updated by Hilko Bengen 1 day ago

The Suricata package in Debian still contains my patch that adds a way to pass the include path to the configure script.

See https://salsa.debian.org/pkg-suricata-team/pkg-suricata/-/blob/master/debian/patches/with-ebpf-includes.patch?ref_type=heads

Actions #8

Updated by Philippe Antoine about 13 hours ago

Cool, should this patch be merged upstream (in Suricata) ? cc @Sascha Steinbiss ?

Actions #9

Updated by Sascha Steinbiss about 7 hours ago

Philippe Antoine wrote in #note-8:

Cool, should this patch be merged upstream (in Suricata) ? cc @Sascha Steinbiss ?

I think so, it would make something configurable which was previously hard-coded.
However, I feel it should then also be documented how to use it (see https://salsa.debian.org/pkg-suricata-team/pkg-suricata/-/blob/master/debian/rules?ref_type=heads#L46 for how it's used in Debian when building the package on eBPF-enabled platforms).

Actions

Also available in: Atom PDF