Bug #3188
closed
I wonder if we could use a coccinelle script to do the heavy lifting here. The pattern
SCLogError(...)
exit()
is quite common.
@Eric Leblond would this be easy to do?
Victor Julien wrote:
I wonder if we could use a coccinelle script to do the heavy lifting here. The pattern
[...]
is quite common. @Eric Leblond would this be easy to do?
Keeping a note. Following is the cocci script:
@@
constant C;
constant char[] msg;
@@
- SCLogError(C,
+ FatalError(SC_ERR_FATAL,
msg);
- exit(EXIT_FAILURE);
Should be applied after #3053 is merged to avoid too many merge conflicts.
Make sure to add the cocci script to the commit message.
- Priority changed from Normal to Low
- Target version changed from 6.0.0beta1 to 7.0.0-beta1
- Status changed from Assigned to Closed
- Priority changed from Low to Normal
- Target version changed from 7.0.0-beta1 to 6.0.0beta1
Also available in: Atom
PDF