Project

General

Profile

Actions
Copy link

Bug #3220

closed

ssl_version keyword negation (!) not working

Added by Min-Gyu Jeon about 6 years ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Philippe Antoine
Target version:
9.0.0-beta1
Affected Versions:
8.0.0
Effort:
Difficulty:
low
Label:

Description

issue

*ssl_version keyword being not detected when using negation (!)
  • ex
    alert tcp any any -> any any (ssl_version:!sslv3)

cause

  • in DetectSslVersionParse() function, the negation info is not used properly.

how to fix

  • use the negation info properly
    • check if other version have negations

Files

ssl-v2.pcap (40.4 KB) ssl-v2.pcap pcap from https://wiki.wireshark.org/SampleCaptures Min-Gyu Jeon, 10/13/2019 11:16 AM

Subtasks 2 (0 open — 2 closed)

Bug #8155: ssl_version keyword negation (!) not working (8.0.x backport)ClosedPhilippe AntoineActions
Bug #8158: ssl_version keyword negation (!) not working (7.0.x backport)ClosedOISF DevActions

Related issues 2 (2 open — 0 closed)

Related to Suricata - Feature #2269: TLS: tls.version: allow negation or comparisonNewCommunity TicketActions
Related to Suricata - Bug #7250: tls version match can have incorrect behaviourNewVictor JulienActions
Actions
Copy link
 #1

Updated by Andreas Herz about 6 years ago

  • Target version set to TBD

As you assigned it to yourself, are you willing to work on this fix?

Actions
Copy link
 #2

Updated by Min-Gyu Jeon about 6 years ago

  • Yes I will summit a PR within this week.
Actions
Copy link
 #4

Updated by Min-Gyu Jeon about 6 years ago

  • Examples.
    • The attached pcap has no any detect events when using a rule
      alert tcp any any -> any any (ssl_version:!tls1.3; sid:1;)
Actions
Copy link
 #5

Updated by Philippe Antoine about 2 years ago

  • Related to Feature #2269: TLS: tls.version: allow negation or comparison added
Actions
Copy link
 #6

Updated by Philippe Antoine 5 months ago

  • Assignee changed from Min-Gyu Jeon to Philippe Antoine
  • Target version changed from TBD to 9.0.0-beta1
Actions
Copy link
 #7

Updated by Philippe Antoine 5 months ago

  • Affected Versions 8.0.0 added
Actions
Copy link
 #8

Updated by Philippe Antoine 4 months ago

  • Related to Bug #7250: tls version match can have incorrect behaviour added
Actions
Copy link
 #9

Updated by Philippe Antoine 2 months ago

  • Status changed from New to Assigned
Actions
Copy link
 #10

Updated by Philippe Antoine 21 days ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #11

Updated by Philippe Antoine 10 days ago

  • Status changed from In Review to Closed
Actions
Copy link
 #12

Updated by Victor Julien 10 days ago

I think we want to backport to 8 and even to 7?

Actions
Copy link
 #13

Updated by Philippe Antoine 9 days ago

  • Status changed from Closed to Resolved
  • Label Needs backport to 8.0 added
Actions
Copy link
 #14

Updated by OISF Ticketbot 9 days ago

  • Subtask #8155 added
Actions
Copy link
 #15

Updated by OISF Ticketbot 9 days ago

  • Label deleted (Needs backport to 8.0)
Actions
Copy link
 #16

Updated by Victor Julien 8 days ago

  • Label Needs backport to 7.0 added
Actions
Copy link
 #17

Updated by OISF Ticketbot 8 days ago

  • Subtask #8158 added
Actions
Copy link
 #18

Updated by OISF Ticketbot 8 days ago

  • Label deleted (Needs backport to 7.0)
Actions
Copy link
 #19

Updated by Philippe Antoine 6 days ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF