Project

General

Profile

Task #3334

Cleanup registration of C function pointers in SuricataContext in main()

Added by Jason Ish over 1 year ago. Updated 2 months ago.

Status:
New
Priority:
High
Assignee:
Target version:
Effort:
Difficulty:
Label:

Description

In Suricata's main() a SuricataContext is setup with no comments on what it is for. This is used to send some C functions as function pointers inside Rust.

This solves a chicken and egg problem when running the Rust unit tests. When the Rust code is simply compiled we can reference any of the C functions, they will get resolved when the resulting Rust library is linked into the C executable. However, when running the Rust unit tests (via cargo test), these C functions don't exist, so the tests fail to compile. To get around this we pass some functions to Rust as pointers wrapped in an Option and resolve it. This process is at best a hack.

At a minimum just clean this up behind some more explicit Rust initialization, but it may be worth researching alternatives.

Also available in: Atom PDF