Bug #3566: rules: minor memory leak involving pcre_get_substring - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #3566

closed

rules: minor memory leak involving pcre_get_substring

Added by Victor Julien over 4 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jeff Lucovsky

Target version:

6.0.0beta1

Affected Versions:

Effort:

Difficulty:

Label:

Needs backport to 4.1, Needs backport to 5.0

Description

To reproduce, compile with '--enable-fuzztargets' and run as

./src/fuzz_siginit ~/Downloads/clusterfuzz-testcase-minimized-fuzz_siginit-5644415478792192 

=================================================================
==28190==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2 byte(s) in 1 object(s) allocated from:
    #0 0x7f92c32f1b40 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb40)
    #1 0x7f92c1efc2b4 in pcre_get_substring (/lib/x86_64-linux-gnu/libpcre.so.3+0x2c2b4)

SUMMARY: AddressSanitizer: 2 byte(s) leaked in 1 allocation(s).

Files

Download all files

clusterfuzz-testcase-minimized-fuzz_siginit-5644415478792192 (35 Bytes) clusterfuzz-testcase-minimized-fuzz_siginit-5644415478792192		Victor Julien, 03/29/2020 12:53 PM
leak-2e099001f4dc598667817341dc6fec77729746fc (121 Bytes) leak-2e099001f4dc598667817341dc6fec77729746fc		Victor Julien, 04/04/2020 06:06 PM

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Jeff Lucovsky over 4 years ago

Status changed from Assigned to In Review

Actions

Copy link

Updated by Victor Julien over 4 years ago

Status changed from In Review to Closed
Label Needs backport to 4.1, Needs backport to 5.0 added

Fixed by: https://github.com/OISF/suricata/commit/2823bc5aed3ade2f916a9592c0ecf214bb62481b

Oss-Fuzz issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21456

Actions

Copy link

Updated by Victor Julien over 4 years ago

Related to Optimization #1046: replace pcre_get_substring with pcre_copy_substring added

Actions

Copy link

Updated by Victor Julien over 4 years ago

File leak-2e099001f4dc598667817341dc6fec77729746fc leak-2e099001f4dc598667817341dc6fec77729746fc added
Status changed from Closed to Assigned

Found another case: ssl_version

==12==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2 byte(s) in 1 object(s) allocated from:
    #0 0x5363cd in malloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:145:3
    #1 0x7f4a52d30bea in pcre_get_substring (/lib/x86_64-linux-gnu/libpcre.so.3+0x26bea)

SUMMARY: AddressSanitizer: 2 byte(s) leaked in 1 allocation(s).

Actions

Copy link