Task #3836
open
Added by Roland Fischer almost 4 years ago.
Updated about 2 months ago.
Description
Side-discussion on clang-formatting code, see #3736
We shall rustfmt rust code.
We shall add a rustfmt check to the build similar to the formatting-check with clang-format that checks a branch' rust changes for correct formatting.
Related issues
1 (1 open — 0 closed)
clang-format checks only work on actual code changes using git-clang-format.
It does not seem that rustfmt supports that functionality yet (or that there is an equivalent a la git-rustfmt).
@jasonish:
Unfortunately I don't think rustfmt is advanced enough in this area. From what I can tell its the complete file or nothing, and being able to just look at the changed lines is still an open issue:
rust-lang/rustfmt#4103
rust-lang/rustfmt#1324
Note, if all of the rust code was already properly formatted, one could just run rustfmt over the whole branch instead of just the changes.
However, that begs the question similar to the C code. Do you want to reformat all rust code in one go? Would probably require some discussion.
- Target version set to 8.0.0-beta1
- Assignee changed from OISF Dev to Philippe Antoine
- Status changed from New to In Review
- Status changed from In Review to In Progress
- Assignee changed from Philippe Antoine to Jason Ish
Taking over, and relating to the source file re-org, as we'll do it all together.
Also available in: Atom
PDF