Project

General

Profile

Actions
Copy link

Bug #3910

closed

datasets: for type string the memcap isn't applied to the string data

Added by Victor Julien about 4 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Shivani Bhardwaj
Target version:
8.0.0-beta1
Affected Versions:
Effort:
Difficulty:
Label:

Description

The memcap checking and tracking only tracks the fixed size THashData and StringType, but not the length of the data in StringType::ptr.

Actions
Copy link
 #1

Updated by Victor Julien about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Victor Julien about 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Shivani Bhardwaj
  • Target version set to 7.0.0-beta1
Actions
Copy link
 #3

Updated by Victor Julien over 3 years ago

One issue is how to deal with upgrades. If suddenly more data is accounted in the memcap, existing setups might suddenly hit the memcap after upgrading.

Actions
Copy link
 #4

Updated by Jason Ish over 3 years ago

I don't see a nice way about it. Does this mostly refer to setting of a memcap in a rule where the user will have a harder time changing it assuming they are getting it from a 3rd source?

Could we define a dataset name under datasets before loading the rule that defines that dataset, the memcap set there would serve as an override?

Actions
Copy link
 #5

Updated by Victor Julien about 3 years ago

  • Target version changed from 7.0.0-beta1 to 8.0.0-beta1
Actions
Copy link
 #6

Updated by Shivani Bhardwaj 7 months ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #7

Updated by Shivani Bhardwaj 5 months ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF