Project

General

Profile

Actions
Copy link

Bug #3924

closed

asan leak htp_connp_create

Added by Peter Manev over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Philippe Antoine
Target version:
6.0.1
Affected Versions:
git master
Effort:
Difficulty:
Label:

Description

affected: 6.0-rc1

Full details in the attached file

                                                                                                                                                                                                           =================================================================                                                                                                                                        [162/1881]
==19123==ERROR: LeakSanitizer: detected memory leaks                                                                                                                                                               

Indirect leak of 784 byte(s) in 2 object(s) allocated from:                                                                                                                                                        
    #0 0x57c6da in calloc (/usr/local/bin/suricata+0x57c6da)                                                                                                                                                       
    #1 0x7feae63a56d8 in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:78:26                                                                                                                   
    #2 0x666307 in Setup /opt/suricata/src/app-layer-htp.c:829:21                                                                                                                                                  
    #3 0x659091 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13                                                                                                                                   
    #4 0x67dff2 in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1233:30                                                                                                                                
    #5 0x5c4e7e in TCPProtoDetect /opt/suricata/src/app-layer.c:458:17                                                                                                                                             
    #6 0x5c2b6b in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:627:13                                                                                                                                      
    #7 0xb5dfb5 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1167:15                                                                                                                      
    #8 0xb5c18b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1228:12                                                                                                                   
    #9 0xb63ee7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9                                                                                                      
    #10 0xb63b70 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #11 0xb388fb in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #12 0xafa5f9 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #13 0xadd719 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #14 0xad3e13 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4861:13
    #15 0xade91c in StreamTcp /opt/suricata/src/stream-tcp.c:5197:11
    #16 0x985977 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #17 0x9848bd in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #18 0xb8e24e in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #19 0xaaf1b2 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #20 0xaa80a0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #21 0xaa6717 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #22 0xa9e040 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #23 0xa9bc17 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #24 0xb9baaf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #25 0x7feae5874fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Files

bug-3924 (22.4 KB) bug-3924 Peter Manev, 09/13/2020 07:36 AM
Actions
Copy link
 #1

Updated by Peter Manev over 3 years ago

Actions
Copy link
 #2

Updated by Victor Julien over 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Philippe Antoine
  • Target version set to 6.0.0
Actions
Copy link
 #3

Updated by Victor Julien over 3 years ago

  • Affected Versions 6.0.0 added
Actions
Copy link
 #4

Updated by Victor Julien over 3 years ago

  • Affected Versions 6.0.0rc1 added
  • Affected Versions deleted (6.0.0)
Actions
Copy link
 #5

Updated by Philippe Antoine over 3 years ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #6

Updated by Philippe Antoine over 3 years ago

  • Status changed from In Review to Closed
Actions
Copy link
 #7

Updated by Peter Manev over 3 years ago

  • Status changed from Closed to New
  • Affected Versions deleted (6.0.0rc1)

This resurfaced with

/usr/local/bin/suricata -V
This is Suricata version 6.0.0-dev (518e0e66c 2020-09-28)

Actions
Copy link
 #8

Updated by Philippe Antoine over 3 years ago

Do you run with configure --enable-debug-validation so that DEBUG_VALIDATE_BUG_ON triggers ?

I think this is a second different leak and that the fix is still good

Actions
Copy link
 #9

Updated by Peter Manev over 3 years ago

I am doing multiple runs trying to get it.
Will report back as soon as i have it.

Actions
Copy link
 #10

Updated by Victor Julien over 3 years ago

  • Target version changed from 6.0.0 to 6.0.1
Actions
Copy link
 #11

Updated by Philippe Antoine over 3 years ago

  • Status changed from New to Assigned
Actions
Copy link
 #12

Updated by Philippe Antoine over 3 years ago

  • Status changed from Assigned to In Review
Actions
Copy link
 #13

Updated by Peter Manev over 3 years ago

Using - https://github.com/OISF/suricata/pull/5527
On exit I get

[108992] 13/11/2020 -- 22:47:22 - (detect-engine-build.c:1722) <Info> (SigAddressCleanupStage1) -- cleaning up signature grouping structure... complete
[108992] 13/11/2020 -- 22:47:22 - (util-device.c:359) <Notice> (LiveDeviceListClean) -- Stats for 'ens1np0':  pkts: 142399907, drop: 0 (0.00%), invalid chksum: 0
[108992] 13/11/2020 -- 22:47:22 - (util-device.c:359) <Notice> (LiveDeviceListClean) -- Stats for 'ens4np0':  pkts: 147605921, drop: 16539 (0.01%), invalid chksum: 0
[108992] 13/11/2020 -- 22:47:22 - (util-mpm-hs.c:1078) <Perf> (MpmHSGlobalCleanup) -- Cleaning up Hyperscan global scratch
[108992] 13/11/2020 -- 22:47:22 - (util-mpm-hs.c:1086) <Perf> (MpmHSGlobalCleanup) -- Clearing Hyperscan database cache

=================================================================
==108992==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 392 byte(s) in 1 object(s) allocated from:
    #0 0x5896ba in calloc (/opt/suritest-tmp/bin/suricata+0x5896ba)
    #1 0x7fd595a9f6d8 in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:78:26
    #2 0x674627 in Setup /opt/suricata/src/app-layer-htp.c:829:21
    #3 0x667271 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13
    #4 0x68c64a in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1258:30
    #5 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #6 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #7 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #8 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #9 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #10 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #11 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #12 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #13 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #14 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #15 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #16 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #17 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #18 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #19 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #20 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #21 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #22 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #23 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #24 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #25 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 128 byte(s) in 1 object(s) allocated from:
    #0 0x5894c3 in __interceptor_malloc (/opt/suritest-tmp/bin/suricata+0x5894c3)
    #1 0x7fd595aa4355 in htp_list_array_init /opt/suricata/libhtp/htp/htp_list.c:47:19
    #2 0x7fd595aa4355 in htp_list_array_create /opt/suricata/libhtp/htp/htp_list.c:69
    #3 0x7fd595a9f037 in htp_conn_create /opt/suricata/libhtp/htp/htp_connection.c:47:26
    #4 0x7fd595a9f6fd in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:85:19
    #5 0x674627 in Setup /opt/suricata/src/app-layer-htp.c:829:21
    #6 0x667271 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13
    #7 0x68c64a in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1258:30
    #8 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #9 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #10 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #11 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #12 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #13 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #14 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #15 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #16 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #17 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #18 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #19 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #20 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #21 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #22 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #23 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #24 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #25 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #26 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #27 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #28 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 104 byte(s) in 1 object(s) allocated from:
    #0 0x5896ba in calloc (/opt/suritest-tmp/bin/suricata+0x5896ba)
    #1 0x7fd595a9f025 in htp_conn_create /opt/suricata/libhtp/htp/htp_connection.c:44:24
    #2 0x7fd595a9f6fd in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:85:19
    #3 0x674627 in Setup /opt/suricata/src/app-layer-htp.c:829:21
    #4 0x667271 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13
    #5 0x68c64a in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1258:30
    #6 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #7 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #8 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #9 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #10 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #11 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #12 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #13 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #14 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #15 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #16 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #17 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #18 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #19 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #20 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #21 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #22 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #23 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #24 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #25 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #26 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 96 byte(s) in 1 object(s) allocated from:
    #0 0x5894c3 in __interceptor_malloc (/opt/suritest-tmp/bin/suricata+0x5894c3)
    #1 0xc68331 in SCMallocFunc /opt/suricata/src/util-mem.c:30:20
    #2 0x678645 in HTPMalloc /opt/suricata/src/app-layer-htp-mem.c:144:11
    #3 0x6663ae in HTPStateAlloc /opt/suricata/src/app-layer-htp.c:347:19
    #4 0x68c398 in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1243:32
    #5 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #6 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #7 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #8 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #9 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #10 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #11 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #12 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #13 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #14 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #15 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #16 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #17 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #18 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #19 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #20 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #21 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #22 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #23 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #24 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #25 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x5894c3 in __interceptor_malloc (/opt/suritest-tmp/bin/suricata+0x5894c3)
    #1 0x7fd595aa4355 in htp_list_array_init /opt/suricata/libhtp/htp/htp_list.c:47:19
    #2 0x7fd595aa4355 in htp_list_array_create /opt/suricata/libhtp/htp/htp_list.c:69
    #3 0x7fd595a9f060 in htp_conn_create /opt/suricata/libhtp/htp/htp_connection.c:53:22
    #4 0x7fd595a9f6fd in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:85:19
    #5 0x674627 in Setup /opt/suricata/src/app-layer-htp.c:829:21
    #6 0x667271 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13
    #7 0x68c64a in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1258:30
    #8 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #9 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #10 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #11 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #12 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #13 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #14 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #15 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #16 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #17 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #18 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #19 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #20 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #21 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #22 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #23 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #24 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #25 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #26 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #27 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #28 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x5896ba in calloc (/opt/suritest-tmp/bin/suricata+0x5896ba)
    #1 0x7fd595aa4340 in htp_list_array_create /opt/suricata/libhtp/htp/htp_list.c:66:27
    #2 0x7fd595a9f037 in htp_conn_create /opt/suricata/libhtp/htp/htp_connection.c:47:26
    #3 0x7fd595a9f6fd in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:85:19
    #4 0x674627 in Setup /opt/suricata/src/app-layer-htp.c:829:21
    #5 0x667271 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13
    #6 0x68c64a in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1258:30
    #7 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #8 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #9 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #10 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #11 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #12 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #13 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #14 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #15 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #16 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #17 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #18 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #19 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #20 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #21 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #22 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #23 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #24 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #25 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #26 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #27 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x5896ba in calloc (/opt/suritest-tmp/bin/suricata+0x5896ba)
    #1 0x7fd595aa4340 in htp_list_array_create /opt/suricata/libhtp/htp/htp_list.c:66:27
    #2 0x7fd595a9f060 in htp_conn_create /opt/suricata/libhtp/htp/htp_connection.c:53:22
    #3 0x7fd595a9f6fd in htp_connp_create /opt/suricata/libhtp/htp/htp_connection_parser.c:85:19
    #4 0x674627 in Setup /opt/suricata/src/app-layer-htp.c:829:21
    #5 0x667271 in HTPHandleRequestData /opt/suricata/src/app-layer-htp.c:879:13
    #6 0x68c64a in AppLayerParserParse /opt/suricata/src/app-layer-parser.c:1258:30
    #7 0x5d1f5e in TCPProtoDetect /opt/suricata/src/app-layer.c:456:17
    #8 0x5cfc2a in AppLayerHandleTCPData /opt/suricata/src/app-layer.c:637:13
    #9 0xb72700 in ReassembleUpdateAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1168:15
    #10 0xb7087b in StreamTcpReassembleAppLayer /opt/suricata/src/stream-tcp-reassemble.c:1231:12
    #11 0xb789e7 in StreamTcpReassembleHandleSegmentUpdateACK /opt/suricata/src/stream-tcp-reassemble.c:1802:9
    #12 0xb78669 in StreamTcpReassembleHandleSegment /opt/suricata/src/stream-tcp-reassemble.c:1845:9
    #13 0xb4cf9b in HandleEstablishedPacketToClient /opt/suricata/src/stream-tcp.c:2445:9
    #14 0xb0ec99 in StreamTcpPacketStateEstablished /opt/suricata/src/stream-tcp.c:2678:13
    #15 0xaf1d89 in StreamTcpStateDispatch /opt/suricata/src/stream-tcp.c:4672:17
    #16 0xae8487 in StreamTcpPacket /opt/suricata/src/stream-tcp.c:4858:13
    #17 0xaf2f8c in StreamTcp /opt/suricata/src/stream-tcp.c:5194:11
    #18 0x998cb7 in FlowWorkerStreamTCPUpdate /opt/suricata/src/flow-worker.c:364:5
    #19 0x997a55 in FlowWorker /opt/suricata/src/flow-worker.c:524:9
    #20 0xba36be in TmThreadsSlotVarRun /opt/suricata/src/tm-threads.c:117:21
    #21 0xac3702 in TmThreadsSlotProcessPkt /opt/suricata/src/./tm-threads.h:192:17
    #22 0xabc5f0 in AFPParsePacketV3 /opt/suricata/src/source-af-packet.c:1113:9
    #23 0xabac67 in AFPWalkBlock /opt/suricata/src/source-af-packet.c:1128:15
    #24 0xab2590 in AFPReadFromRingV3 /opt/suricata/src/source-af-packet.c:1178:15
    #25 0xab0167 in ReceiveAFPLoop /opt/suricata/src/source-af-packet.c:1571:17
    #26 0xbb0fcf in TmThreadsSlotPktAcqLoop /opt/suricata/src/tm-threads.c:312:13
    #27 0x7fd594f63fa2 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7fa2)

SUMMARY: AddressSanitizer: 864 byte(s) leaked in 7 allocation(s).
Actions
Copy link
 #14

Updated by Philippe Antoine over 3 years ago

New branch to test :
https://github.com/catenacyber/suricata/tree/proto-change-gap-leak-3924-v1

There is likely a new bug indeed : gaps during protocol change...

Actions
Copy link
 #16

Updated by Peter Manev over 3 years ago

With latest updates of the branch it behaves much better so far.

Actions
Copy link
 #17

Updated by Peter Manev over 3 years ago

Confirming - no leaks - latest updates looks much better.

Actions
Copy link
 #19

Updated by Philippe Antoine over 3 years ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF