Project

General

Profile

Task #4182

lua: Use lua_pushinteger for pushing integer types as integers instead of floats

Added by Jason Ish 7 months ago. Updated about 1 month ago.

Status:
New
Priority:
Normal
Target version:
Effort:
low
Difficulty:
low
Label:

Description

Prior to Lua 5.3, Lua only had one number type, float. Now that Lua 5.1 has integer types it makes sense to push integer values, specifically those around flow and packet tuples as integers. Luajit 5.1 and Liblua 5.0 has lua_pushinteger so compatibility should not be an issue.

Suricata-Verify test cases for SCPacketTuple() and SCFlowTuple() should also be created to show that they pass before and after this change without modification.


Related issues

Related to Support #4088: SCPacketTuple() not return correct protocol typeNewActions
#1

Updated by Jason Ish 7 months ago

  • Related to Support #4088: SCPacketTuple() not return correct protocol type added
#2

Updated by Victor Julien about 1 month ago

  • Assignee changed from OISF Dev to Juliana Fajardini Reichow

Also available in: Atom PDF