Project

General

Profile

Actions

Task #4182

closed

lua: Use lua_pushinteger for pushing integer types as integers instead of floats

Added by Jason Ish about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
low
Difficulty:
low
Label:
Needs backport to 6.0

Description

Prior to Lua 5.3, Lua only had one number type, float. Now that Lua 5.1 has integer types it makes sense to push integer values, specifically those around flow and packet tuples as integers. Luajit 5.1 and Liblua 5.0 has lua_pushinteger so compatibility should not be an issue.

Suricata-Verify test cases for SCPacketTuple() and SCFlowTuple() should also be created to show that they pass before and after this change without modification.


Related issues 2 (0 open2 closed)

Related to Support #4088: SCPacketTuple() not return correct protocol typeClosedActions
Copied to Bug #4712: lua: Use lua_pushinteger for pushing integer types as integers instead of floatsClosedShivani BhardwajActions
Actions #1

Updated by Jason Ish about 2 years ago

  • Related to Support #4088: SCPacketTuple() not return correct protocol type added
Actions #2

Updated by Victor Julien over 1 year ago

  • Assignee changed from OISF Dev to Juliana Fajardini Reichow
Actions #3

Updated by Juliana Fajardini Reichow over 1 year ago

  • Status changed from New to In Progress
Actions #5

Updated by Juliana Fajardini Reichow over 1 year ago

  • Status changed from In Progress to In Review
Actions #6

Updated by Juliana Fajardini Reichow about 1 year ago

  • Status changed from In Review to Closed
Actions #7

Updated by Shivani Bhardwaj about 1 year ago

  • Label Needs backport to 6.0 added
Actions #8

Updated by Shivani Bhardwaj about 1 year ago

  • Copied to Bug #4712: lua: Use lua_pushinteger for pushing integer types as integers instead of floats added
Actions

Also available in: Atom PDF