Actions
Task #4182
closedlua: Use lua_pushinteger for pushing integer types as integers instead of floats
Effort:
low
Difficulty:
low
Label:
Needs backport to 6.0
Description
Prior to Lua 5.3, Lua only had one number type, float. Now that Lua 5.1 has integer types it makes sense to push integer values, specifically those around flow and packet tuples as integers. Luajit 5.1 and Liblua 5.0 has lua_pushinteger so compatibility should not be an issue.
Suricata-Verify test cases for SCPacketTuple() and SCFlowTuple() should also be created to show that they pass before and after this change without modification.
Updated by Jason Ish over 3 years ago
- Related to Support #4088: SCPacketTuple() not return correct protocol type added
Updated by Victor Julien almost 3 years ago
- Assignee changed from OISF Dev to Juliana Fajardini Reichow
Updated by Juliana Fajardini Reichow almost 3 years ago
- Status changed from New to In Progress
Updated by Juliana Fajardini Reichow almost 3 years ago
PR for review: https://github.com/OISF/suricata/pull/6254
Updated by Juliana Fajardini Reichow over 2 years ago
- Status changed from In Progress to In Review
Updated by Juliana Fajardini Reichow over 2 years ago
- Status changed from In Review to Closed
Merged in: https://github.com/OISF/suricata/pull/6383
Updated by Shivani Bhardwaj over 2 years ago
- Copied to Bug #4712: lua: Use lua_pushinteger for pushing integer types as integers instead of floats added
Actions