Project

General

Profile

Actions

Bug #4712

closed

lua: Use lua_pushinteger for pushing integer types as integers instead of floats

Added by Shivani Bhardwaj 24 days ago. Updated 16 days ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
low
Difficulty:
Label:

Description

Prior to Lua 5.3, Lua only had one number type, float. Now that Lua 5.1 has integer types it makes sense to push integer values, specifically those around flow and packet tuples as integers. Luajit 5.1 and Liblua 5.0 has lua_pushinteger so compatibility should not be an issue.

Suricata-Verify test cases for SCPacketTuple() and SCFlowTuple() should also be created to show that they pass before and after this change without modification.


Related issues

Copied from Task #4182: lua: Use lua_pushinteger for pushing integer types as integers instead of floatsClosedJuliana Fajardini ReichowActions
Actions #1

Updated by Shivani Bhardwaj 24 days ago

  • Copied from Task #4182: lua: Use lua_pushinteger for pushing integer types as integers instead of floats added
Actions #2

Updated by Shivani Bhardwaj 24 days ago

  • Status changed from New to In Review
  • Priority changed from Normal to High
Actions #3

Updated by Shivani Bhardwaj 24 days ago

  • Label deleted (Needs backport to 6.0)
Actions #4

Updated by Victor Julien 16 days ago

  • Tracker changed from Task to Bug
  • Status changed from In Review to Closed
  • Priority changed from High to Normal
  • Difficulty deleted (low)
Actions

Also available in: Atom PDF