Project

General

Profile

Actions
Copy link

Bug #4246

closed
PA VJ

Assertion failed in AdjustToAcked delta > 10000000ULL && delta > stream->window

Bug #4246: Assertion failed in AdjustToAcked delta > 10000000ULL && delta > stream->window

Added by Philippe Antoine over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Victor Julien
Target version:
7.0.0-beta1
Affected Versions:
6.0.1
Effort:
Difficulty:
Label:
Needs backport to 5.0, Needs backport to 6.0

Description

Files

lol.pcapng (4.8 KB) lol.pcapng Suricata reproducer Philippe Antoine, 12/30/2020 08:51 PM

Related issues 2 (0 open — 2 closed)

Copied to Suricata - Bug #4341: Assertion failed in AdjustToAcked delta > 10000000ULL && delta > stream->windowClosedJeff LucovskyActions
Copied to Suricata - Bug #4342: Assertion failed in AdjustToAcked delta > 10000000ULL && delta > stream->windowClosedVictor JulienActions

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #1

I do not know if this assertion is right.

I understand that the scenario to trigger this is :
Have a stream with a very big window > 10000000ULL, with tcp window being 0xFFFF and scale factor 8
Grow delta ie stream->last_ack - stream->base_seq bigger than 10000000ULL but smaller than window
Then have a packet with a small window, and delta will not have changed. Hence the assertion will trigger

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #3

  • Assignee set to Victor Julien

VJ Updated by Victor Julien over 5 years ago Actions
Copy link
 #4

  • Status changed from New to Assigned

VJ Updated by Victor Julien over 5 years ago Actions
Copy link
 #5

I've not been able to get this to trigger with the pcap. How are you running it?

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #6

The pcap seems not to be a reproducer now...
Will try to craft another one later

PA Updated by Philippe Antoine over 5 years ago Actions
Copy link
 #7

suricata -r lol.pcapng -k none -c suricata.yaml
Trick is to enable HTTP2 in suricata.yaml

VJ Updated by Victor Julien about 5 years ago Actions
Copy link
 #8

  • Status changed from Assigned to Closed
  • Private changed from Yes to No
  • Label Needs backport to 5.0, Needs backport to 6.0 added

PA Updated by Philippe Antoine about 5 years ago Actions
Copy link
 #9

  • Status changed from Closed to In Progress

Fix seems incomplete as per https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=30885
fuzz_sigpcap: stream-tcp-reassemble.c:989: _Bool CheckGap(TcpSession *, TcpStream *, Packet *): Assertion `!((delta > 10000000ULL && delta > stream->window))' failed.

JL Updated by Jeff Lucovsky about 5 years ago Actions
Copy link
 #10

  • Copied to Bug #4341: Assertion failed in AdjustToAcked delta > 10000000ULL && delta > stream->window added

JL Updated by Jeff Lucovsky about 5 years ago Actions
Copy link
 #11

  • Copied to Bug #4342: Assertion failed in AdjustToAcked delta > 10000000ULL && delta > stream->window added

VJ Updated by Victor Julien about 5 years ago Actions
Copy link
 #12

  • Status changed from In Progress to Closed
  • Target version changed from 6.0.2 to 7.0.0-beta1
Actions
Copy link

Also available in: PDF Atom