Project

General

Profile

Actions
Copy link

Optimization #4599

closed
JF JI

Optimization #4591: Fix Rust clippy lints

Fix warning about "ptr_arg"

Optimization #4599: Fix warning about "ptr_arg"

Added by Juliana Fajardini Reichow over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jason Ish
Target version:
7.0.0-beta1
Effort:
Difficulty:
Label:
Beginner, Good First Issue, Outreachy, Rust

Description

We are working on cleaning our Rust code from lint warnings.

For resolving this issue, please check the rust code and fix warnings related to "ptr_arg", or along the lines of "writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices"

For more details on this warning, check
https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

More information on the parent issue.

Updated by Anonymous over 3 years ago Actions
Copy link
 #1

Hello,

Can I claim this issue?

JF Updated by Juliana Fajardini Reichow over 3 years ago Actions
Copy link
 #2

Hello!

Sure, thanks. We'll assign it to you. Meanwhile, feel free to start working on it. :)

JF Updated by Juliana Fajardini Reichow over 3 years ago Actions
Copy link
 #3

  • Assignee set to Anonymous

SB Updated by Shivani Bhardwaj over 3 years ago Actions
Copy link
 #4

  • Target version set to 7.0.0-beta1

Updated by Anonymous over 3 years ago Actions
Copy link
 #5

  • Status changed from New to In Review

JF Updated by Juliana Fajardini Reichow over 3 years ago Actions
Copy link
 #6

A PR was done for this, although I think the person has decided not to work on this anymore (can't find their account anymore):

https://github.com/OISF/suricata/pull/8002

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
 #7

  • Status changed from In Review to New
  • Target version deleted (7.0.0-beta1)

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
 #8

  • Status changed from New to In Review
  • Assignee set to Jason Ish
  • Target version set to 7.0.0-beta1

Guess this is part of Jason's staging branch.

SB Updated by Shivani Bhardwaj over 3 years ago Actions
Copy link
 #9

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: PDF Atom