Project

General

Profile

Actions
Copy link

Optimization #4599

closed

Optimization #4591: Fix Rust clippy lints

Fix warning about "ptr_arg"

Added by Juliana Fajardini Reichow over 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jason Ish
Target version:
7.0.0-beta1
Effort:
Difficulty:
Label:
Beginner, Good First Issue, Outreachy, Rust

Description

We are working on cleaning our Rust code from lint warnings.

For resolving this issue, please check the rust code and fix warnings related to "ptr_arg", or along the lines of "writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices"

For more details on this warning, check
https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

More information on the parent issue.

Actions
Copy link
 #1

Updated by Anonymous about 2 years ago

Hello,

Can I claim this issue?

Actions
Copy link
 #2

Updated by Juliana Fajardini Reichow about 2 years ago

Hello!

Sure, thanks. We'll assign it to you. Meanwhile, feel free to start working on it. :)

Actions
Copy link
 #3

Updated by Juliana Fajardini Reichow about 2 years ago

  • Assignee set to Anonymous
Actions
Copy link
 #4

Updated by Shivani Bhardwaj about 2 years ago

  • Target version set to 7.0.0-beta1
Actions
Copy link
 #5

Updated by Anonymous about 2 years ago

  • Status changed from New to In Review
Actions
Copy link
 #6

Updated by Juliana Fajardini Reichow about 2 years ago

A PR was done for this, although I think the person has decided not to work on this anymore (can't find their account anymore):

https://github.com/OISF/suricata/pull/8002

Actions
Copy link
 #7

Updated by Victor Julien about 2 years ago

  • Status changed from In Review to New
  • Target version deleted (7.0.0-beta1)
Actions
Copy link
 #8

Updated by Victor Julien about 2 years ago

  • Status changed from New to In Review
  • Assignee set to Jason Ish
  • Target version set to 7.0.0-beta1

Guess this is part of Jason's staging branch.

Actions
Copy link
 #9

Updated by Shivani Bhardwaj about 2 years ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF