Project

General

Profile

Actions
Copy link

Bug #5012

closed
PA

Remove duplicate definition of constants between C and Rust

Bug #5012: Remove duplicate definition of constants between C and Rust

Added by Philippe Antoine over 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
TBD
Affected Versions:
git main
Effort:
Difficulty:
Label:

Description

Discussion comes from https://github.com/OISF/suricata/pull/6840

PGSQL_LOG_PASSWORDS is not exported by cbindgen

With the following patch

-pub const PGSQL_LOG_PASSWORDS: u32 = BIT_U32!(1);
+pub const PGSQL_LOG_PASSWORDS: u32 = 2;

it does get exported

FLOW_DIR_REVERSED is another example

CI should ensure this get no longer added

Related issues 2 (1 open — 1 closed)

Related to Suricata - Bug #5007: pgsql: coverity warningClosedJuliana Fajardini ReichowActions
Related to Suricata - Optimization #4517: cbindgen export the constants from Rust to C, also for macro such as BIT_U8(1), and remove duplicate definitions between rust and CAssignedOISF DevActions
Actions
Copy link

Also available in: PDF Atom