Project

General

Profile

Actions

Bug #5073

closed

Off-by-one in flow-manager flow_hash row allocation

Added by Arne Welzel 8 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
low
Difficulty:
Label:
Needs backport to 5.0, Needs backport to 6.0

Description

When configuring more than one flow manager, a single row between the per-flow-manager ranges is left-out.

The current code doesn't cover all rows when more than one flow manager is
used. It leaves a single row between ftd->max and ftd->min of the next
manager orphaned. As an example:

hash_size=1000
flowmgr_number=3
range=333

instance  ftd->min  ftd->max
0         0         333
1         334       666
2         667       1000

Rows not covered: 333, 666

PR: https://github.com/OISF/suricata/pull/6993


Related issues 2 (0 open2 closed)

Copied to Bug #5112: Off-by-one in flow-manager flow_hash row allocationClosedShivani BhardwajActions
Copied to Bug #5113: Off-by-one in flow-manager flow_hash row allocationClosedJeff LucovskyActions
Actions #1

Updated by Arne Welzel 8 months ago

  • Status changed from New to In Review
Actions #2

Updated by Jeff Lucovsky 8 months ago

  • Label Needs backport to 5.0, Needs backport to 6.0 added
Actions #3

Updated by Jeff Lucovsky 8 months ago

  • Target version changed from TBD to 7.0rc1
  • Affected Versions 5.0.8 added
Actions #4

Updated by Jeff Lucovsky 8 months ago

  • Copied to Bug #5112: Off-by-one in flow-manager flow_hash row allocation added
Actions #5

Updated by Jeff Lucovsky 8 months ago

  • Copied to Bug #5113: Off-by-one in flow-manager flow_hash row allocation added
Actions #6

Updated by Jeff Lucovsky 8 months ago

  • Assignee changed from OISF Dev to Arne Welzel
Actions #7

Updated by Jeff Lucovsky 6 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF