Bug #5073: Off-by-one in flow-manager flow_hash row allocation - Suricata - Open Information Security Foundation

Actions

Copy link

Bug #5073

closed

AW AW

Off-by-one in flow-manager flow_hash row allocation

Bug #5073: Off-by-one in flow-manager flow_hash row allocation

Added by Arne Welzel about 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Arne Welzel

Target version:

7.0.0-beta1

Affected Versions:

5.0.8, 6.0.4

Effort:

low

Difficulty:

Label:

Needs backport to 5.0, Needs backport to 6.0

Description

When configuring more than one flow manager, a single row between the per-flow-manager ranges is left-out.

The current code doesn't cover all rows when more than one flow manager is
used. It leaves a single row between ftd->max and ftd->min of the next
manager orphaned. As an example:

hash_size=1000
flowmgr_number=3
range=333

instance  ftd->min  ftd->max
0         0         333
1         334       666
2         667       1000

Rows not covered: 333, 666

PR: https://github.com/OISF/suricata/pull/6993

Related issues 2 (0 open — 2 closed)