Project

General

Profile

Actions

Bug #5576

open

Dataset is setting data despite the signature being a complete match

Added by Andreas Herz about 2 years ago. Updated 3 months ago.

Status:
In Review
Priority:
Normal
Target version:
Affected Versions:
Effort:
Difficulty:
Label:

Description

The following rule doesn't match on the content of the pcap:

alert http any any -> $HOME_NET any (msg:"HTTP learning"; flow:established,to_client; http.content_type; content:"noone"; http.server; content:"ECS"; fast_pattern; dataset:set,http,type string,state output/http.intel; sid:2; rev:1; priority:2;)

But the data for the dataset is still set. This is not expected if we compare datasets to behave like flowbits at that point. A flowbit is only set POSTMATCH, so dataset should as well when setting actual data to a set.

Attached pcap to reproduce it.
Suricata-Verify test will follow


Files

input.pcap (1.88 KB) input.pcap Andreas Herz, 10/14/2022 11:33 AM

Related issues 3 (1 open2 closed)

Related to Suricata - Security #7195: datasets: rule with unset makes suricata abortClosedPhilippe AntoineActions
Related to Suricata - Bug #7197: detect/flowvars: persist if the inspection happens on multiple packetsNewOISF DevActions
Related to Suricata - Bug #7326: detect/multi-buffer/prefilter: false negative if the first packet does not have all occurences with http.request_headerClosedPhilippe AntoineActions
Actions #2

Updated by Victor Julien about 2 years ago

The set-alert pattern is used to match on the initial set.

Actions #3

Updated by Eric Leblond about 2 years ago

  • Status changed from Assigned to In Review
  • Assignee changed from Shivani Bhardwaj to Eric Leblond
Actions #4

Updated by Philippe Antoine 4 months ago

  • Assignee changed from Eric Leblond to Philippe Antoine
  • Target version changed from TBD to 8.0.0-beta1
Actions #5

Updated by Philippe Antoine 4 months ago

  • Status changed from In Review to In Progress
Actions #6

Updated by Philippe Antoine 4 months ago

  • Related to Security #7195: datasets: rule with unset makes suricata abort added
Actions #7

Updated by Philippe Antoine 4 months ago

  • Related to Bug #7197: detect/flowvars: persist if the inspection happens on multiple packets added
Actions #8

Updated by Philippe Antoine 3 months ago

  • Status changed from In Progress to In Review
Actions #9

Updated by Philippe Antoine about 1 month ago

  • Related to Bug #7326: detect/multi-buffer/prefilter: false negative if the first packet does not have all occurences with http.request_header added
Actions

Also available in: Atom PDF