Project

General

Profile

Actions
Copy link

Bug #5789

closed
MK MK

output api: int handling issue

Bug #5789: output api: int handling issue

Added by Maxim Korotkov about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Maxim Korotkov
Target version:
7.0.0-rc2
Affected Versions:
git main
Effort:
low
Difficulty:
Label:
C, Good First Issue

Description

https://github.com/OISF/suricata/blob/55c4834e4e9b14a441b735f84d8d35b4eb151702/src/output-tx.c#L122
A logical error may have been made here. Comparison with the upper bound of the variable type does not make sense. It may be worth adding the caste of one of the multiplication operands to the 64 bit type for avoiding overflow
Found by Security Code with Svace static analyzer

MK Updated by Maxim Korotkov about 3 years ago Actions
Copy link
 #1

  • Description updated (diff)

JL Updated by Jeff Lucovsky about 3 years ago Actions
Copy link
 #3

  • Status changed from New to In Review

JF Updated by Juliana Fajardini Reichow over 2 years ago Actions
Copy link
 #4

  • Status changed from In Review to Closed

VJ Updated by Victor Julien over 2 years ago Actions
Copy link
 #5

  • Subject changed from Logic error to output api: int handling issue

VJ Updated by Victor Julien over 2 years ago Actions
Copy link
 #6

  • Target version changed from TBD to 7.0.0-rc2
Actions
Copy link

Also available in: PDF Atom