Project

General

Profile

Actions
Copy link

Bug #5789

closed

output api: int handling issue

Added by Maxim Korotkov over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Maxim Korotkov
Target version:
7.0.0-rc2
Affected Versions:
git master
Effort:
low
Difficulty:
Label:
C, Good First Issue

Description

https://github.com/OISF/suricata/blob/55c4834e4e9b14a441b735f84d8d35b4eb151702/src/output-tx.c#L122
A logical error may have been made here. Comparison with the upper bound of the variable type does not make sense. It may be worth adding the caste of one of the multiplication operands to the 64 bit type for avoiding overflow
Found by Security Code with Svace static analyzer

Actions
Copy link
 #1

Updated by Maxim Korotkov over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Jeff Lucovsky over 2 years ago

  • Status changed from New to In Review
Actions
Copy link
 #4

Updated by Juliana Fajardini Reichow almost 2 years ago

  • Status changed from In Review to Closed
Actions
Copy link
 #5

Updated by Victor Julien almost 2 years ago

  • Subject changed from Logic error to output api: int handling issue
Actions
Copy link
 #6

Updated by Victor Julien almost 2 years ago

  • Target version changed from TBD to 7.0.0-rc2
Actions
Copy link

Also available in: Atom PDF