Project

General

Profile

Actions

Bug #5789

closed

output api: int handling issue

Added by Maxim Korotkov almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Effort:
low
Difficulty:
Label:
C, Good First Issue

Description

https://github.com/OISF/suricata/blob/55c4834e4e9b14a441b735f84d8d35b4eb151702/src/output-tx.c#L122
A logical error may have been made here. Comparison with the upper bound of the variable type does not make sense. It may be worth adding the caste of one of the multiplication operands to the 64 bit type for avoiding overflow
Found by Security Code with Svace static analyzer

Actions

Also available in: Atom PDF