Bug #5821
closedsmtp-eve s-v test #4 does not pass on master-6.0.x
Description
With the fix in the version checks of suricata-verify (ref: https://github.com/OISF/suricata-verify/pull/1098), this test started to fail.
Difference from expected behavior: Different file size
Needs analysis why the failure happens.
SB Updated by Shivani Bhardwaj about 3 years ago
- Description updated (diff)
VJ Updated by Victor Julien about 3 years ago
- Priority changed from Normal to High
SB Updated by Shivani Bhardwaj about 3 years ago
- Related to Bug #5725: smtp: quoted-printable encoding skips empty lines in files added
SB Updated by Shivani Bhardwaj about 3 years ago
- Status changed from Assigned to In Review
In Review PR: https://github.com/OISF/suricata-verify/pull/1139
PA Updated by Philippe Antoine about 3 years ago
@Shivani Bhardwaj was this fixed by S-V commit 579814085904075b95865d33bd376cb0426c137c ?
PA Updated by Philippe Antoine about 3 years ago
I do not think we want to backport #5725 as it may be considered a breaking change
If so, the S-V check should only include the new file size for Suricata version 6
What about test smtp-file-data-02 ?
SB Updated by Shivani Bhardwaj about 3 years ago
Philippe Antoine wrote in #note-5:
@Shivani Bhardwaj was this fixed by S-V commit 579814085904075b95865d33bd376cb0426c137c ?
This issue in smtp tests was found with this commit.
SB Updated by Shivani Bhardwaj about 3 years ago
Philippe Antoine wrote in #note-6:
I do not think we want to backport #5725 as it may be considered a breaking change
It has already been backported: https://redmine.openinfosecfoundation.org/issues/5735
If so, the S-V check should only include the new file size for Suricata version 6
What about test smtp-file-data-02 ?
Seems like it works at it is set to require min-version: 6
VJ Updated by Victor Julien about 3 years ago
- Status changed from In Review to Closed
- Priority changed from High to Normal
- Target version deleted (
6.0.11)