Project

General

Profile

Actions

Feature #6480

closed

plugins: allow plugins to specify the version of suricata they are for

Added by Jason Ish over 1 year ago. Updated 1 day ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Still needs some thought. But would happen at plugin registration time.

Actions #1

Updated by Philippe Antoine over 1 year ago

Remark: there should be some API stability at some point like https://github.com/OISF/suricata/pull/9662 changes the prototype of SigMatchAppendSMToList and would break plugins using this...

Actions #2

Updated by Jason Ish over 1 year ago

Philippe Antoine wrote in #note-1:

Remark: there should be some API stability at some point like https://github.com/OISF/suricata/pull/9662 changes the prototype of SigMatchAppendSMToList and would break plugins using this...

I think we are OK to break the API at major version points, ideally we won't but I don't think its a promise we can make.

Actions #3

Updated by Jason Ish 10 months ago

  • Assignee changed from OISF Dev to Jason Ish

There are 2 things here:
- A plugin build should have the ability to check the version of Suricata it is building against. But that's going to be highly depending on the build tool.
- Encode the version in the binary so a plugin built for 7 will fail to load in 8, which is the focus of this ticket.

Actions #4

Updated by Philippe Antoine 3 months ago

For app-layer plugins `SCAppLayerPlugin` structure has first a version field that suricata checks against its `SC_PLUGIN_API_VERSION`(maybe we should log more error messages in `SCPluginRegisterAppLayer`

Actions #5

Updated by Jason Ish 3 days ago

  • Status changed from New to Closed
  • Assignee changed from Jason Ish to Philippe Antoine

Complete along with other plugin work.

Actions #6

Updated by Philippe Antoine 1 day ago

Was done by commit c164cfcf6b74ebc81f6577920a40ccbe30dbe669 to be precise

Actions

Also available in: Atom PDF