Added by Jason Ish over 2 years ago. Updated about 1 year ago.
Description
Still needs some thought. But would happen at plugin registration time.
Remark: there should be some API stability at some point like https://github.com/OISF/suricata/pull/9662 changes the prototype of SigMatchAppendSMToList and would break plugins using this...
Philippe Antoine wrote in #note-1:
Remark: there should be some API stability at some point like https://github.com/OISF/suricata/pull/9662 changes the prototype of
SigMatchAppendSMToListand would break plugins using this...
I think we are OK to break the API at major version points, ideally we won't but I don't think its a promise we can make.
There are 2 things here:
- A plugin build should have the ability to check the version of Suricata it is building against. But that's going to be highly depending on the build tool.
- Encode the version in the binary so a plugin built for 7 will fail to load in 8, which is the focus of this ticket.
For app-layer plugins `SCAppLayerPlugin` structure has first a version field that suricata checks against its `SC_PLUGIN_API_VERSION`(maybe we should log more error messages in `SCPluginRegisterAppLayer`
Complete along with other plugin work.
Was done by commit c164cfcf6b74ebc81f6577920a40ccbe30dbe669 to be precise