Project

General

Profile

Actions
Copy link

Bug #8258

closed

ldap: no invalid_data event in case of invalid request

Added by Giuseppe Longo about 1 month ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Giuseppe Longo
Target version:
9.0.0-beta1
Affected Versions:
git main
Effort:
Difficulty:
Label:

Description

While reviewing the LDAP code, I noticed that in parse_request:

1. tx.tx_data.updated_ts is not set to true when a new transaction is created.
2. LdapEvent::InvalidData is not set when a request is not parsed correctly.

Subtasks 1 (0 open — 1 closed)

Bug #8317: ldap: no invalid_data event in case of invalid request (8.0.x backport)ClosedGiuseppe LongoActions
Actions
Copy link
 #1

Updated by Victor Julien about 1 month ago

  • Status changed from New to In Progress
  • Target version changed from TBD to 9.0.0-beta1
  • Affected Versions git main added
  • Affected Versions deleted (9.0.0-beta1)

Do we need a backport to 8 as well? Is there a test?

Actions
Copy link
 #2

Updated by Philippe Antoine about 1 month ago

  • Subject changed from ldap: set tx_data.updated_ts and invalid_data event to ldap: set invalid_data event

1. tx.tx_data.updated_ts is not set to true when a new transaction is created.

For me this statement is wrong, tx.tx_data.updated_ts is set to true when a new transaction is created.

2. LdapEvent::InvalidData is not set when a request is not parsed correctly.

There is a missed case here indeed

Actions
Copy link
 #3

Updated by Philippe Antoine about 1 month ago

  • Subject changed from ldap: set invalid_data event to ldap: set invalid_data event in all cases
Actions
Copy link
 #4

Updated by Giuseppe Longo 20 days ago

  • Target version changed from 9.0.0-beta1 to 8.0.4
Actions
Copy link
 #5

Updated by Victor Julien 20 days ago

  • Target version changed from 8.0.4 to 9.0.0-beta1
  • Label Needs backport to 8.0 added
Actions
Copy link
 #6

Updated by OISF Ticketbot 20 days ago

  • Subtask #8317 added
Actions
Copy link
 #7

Updated by OISF Ticketbot 20 days ago

  • Label deleted (Needs backport to 8.0)
Actions
Copy link
 #8

Updated by Shivani Bhardwaj 10 days ago

  • Subject changed from ldap: set invalid_data event in all cases to ldap: no invalid_data event in case of invalid request
Actions
Copy link
 #9

Updated by Philippe Antoine 10 days ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #10

Updated by Philippe Antoine 6 days ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF