Project

General

Profile

Actions
Copy link

Bug #8258

open

ldap: set invalid_data event in all cases

Added by Giuseppe Longo 4 days ago. Updated about 17 hours ago.

Status:
In Progress
Priority:
Normal
Assignee:
Giuseppe Longo
Target version:
9.0.0-beta1
Affected Versions:
git main
Effort:
Difficulty:
Label:

Description

While reviewing the LDAP code, I noticed that in parse_request:

1. tx.tx_data.updated_ts is not set to true when a new transaction is created.
2. LdapEvent::InvalidData is not set when a request is not parsed correctly.

Actions
Copy link
 #1

Updated by Victor Julien 4 days ago

  • Status changed from New to In Progress
  • Target version changed from TBD to 9.0.0-beta1
  • Affected Versions git main added
  • Affected Versions deleted (9.0.0-beta1)

Do we need a backport to 8 as well? Is there a test?

Actions
Copy link
 #2

Updated by Philippe Antoine about 17 hours ago

  • Subject changed from ldap: set tx_data.updated_ts and invalid_data event to ldap: set invalid_data event

1. tx.tx_data.updated_ts is not set to true when a new transaction is created.

For me this statement is wrong, tx.tx_data.updated_ts is set to true when a new transaction is created.

2. LdapEvent::InvalidData is not set when a request is not parsed correctly.

There is a missed case here indeed

Actions
Copy link
 #3

Updated by Philippe Antoine about 17 hours ago

  • Subject changed from ldap: set invalid_data event to ldap: set invalid_data event in all cases
Actions
Copy link

Also available in: Atom PDF