Optimization #879
closedupdate configure.ac with autoupdate
Added by Victor Julien almost 13 years ago. Updated almost 7 years ago.
Description
The autoupdate tool modernizes configure.ac and cleans up formatting. Might be interesting to try it.
EL Updated by Eric Leblond almost 13 years ago Actions #1
- % Done changed from 0 to 90
Implemented by https://github.com/inliniac/suricata/pull/493
VJ Updated by Victor Julien over 12 years ago Actions #2
- Target version changed from 2.0beta2 to TBD
- % Done changed from 90 to 10
This turned out to have side effects on older platforms, so postponing for now.
VJ Updated by Victor Julien over 12 years ago Actions #3
- Tracker changed from Feature to Optimization
AH Updated by Andreas Herz almost 10 years ago Actions #4
- Assignee changed from Eric Leblond to Andreas Herz
Worth looking at it again when we now try to make configure.ac consistent.
AH Updated by Andreas Herz over 8 years ago Actions #5
Since some time has passed I would like to give it a new try:
https://github.com/inliniac/suricata/pull/2904
It would be nice if some of you could test that on your distributions as well. I tested it on ArchLinux and Ubuntu 16.04 LTS.
AH Updated by Andreas Herz over 8 years ago Actions #6
It would also help for some other improvements within our configure script like #1835 and would like to have it merged to use it for the future work on those configure tasks.
AH Updated by Andreas Herz over 8 years ago Actions #7
With all the other PR I would also suggest we add some sort of check within the buildbot so we won't get back old (not modern) configure.ac
AH Updated by Andreas Herz about 7 years ago Actions #8
Eric and I need to discuss this with regards to the possible checks within the buildbot
AH Updated by Andreas Herz almost 7 years ago Actions #9
Should we close this, since we converted it or should we wait until we have some sort of check at the QA that we don't reintroduce old behaviour?
VJ Updated by Victor Julien almost 7 years ago Actions #10
- Status changed from Assigned to Closed
- Target version changed from TBD to 5.0rc1
https://github.com/OISF/suricata/pull/3955
I don't think the QA part of this is critical. Errors will be caught by existing QA. We can review changes, as well as the whole thing regularly.