Actions
Optimization #879
closedupdate configure.ac with autoupdate
Effort:
Difficulty:
Label:
Description
The autoupdate tool modernizes configure.ac and cleans up formatting. Might be interesting to try it.
Actions
Added by Victor Julien over 12 years ago. Updated over 6 years ago.
Description
The autoupdate tool modernizes configure.ac and cleans up formatting. Might be interesting to try it.
Implemented by https://github.com/inliniac/suricata/pull/493
This turned out to have side effects on older platforms, so postponing for now.
Worth looking at it again when we now try to make configure.ac consistent.
Since some time has passed I would like to give it a new try:
https://github.com/inliniac/suricata/pull/2904
It would be nice if some of you could test that on your distributions as well. I tested it on ArchLinux and Ubuntu 16.04 LTS.
It would also help for some other improvements within our configure script like #1835 and would like to have it merged to use it for the future work on those configure tasks.
With all the other PR I would also suggest we add some sort of check within the buildbot so we won't get back old (not modern) configure.ac
Eric and I need to discuss this with regards to the possible checks within the buildbot
Should we close this, since we converted it or should we wait until we have some sort of check at the QA that we don't reintroduce old behaviour?
https://github.com/OISF/suricata/pull/3955
I don't think the QA part of this is critical. Errors will be caught by existing QA. We can review changes, as well as the whole thing regularly.