Project

General

Profile

Actions

Feature #3082

open

suricata-verify: option to test 'skipped' tests

Added by Victor Julien about 2 years ago. Updated 28 days ago.

Status:
New
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:
Python

Description

Now that the number of tests is growing a new issue appears: which of the http evader tests are supposed to no longer be skipped after the last merges? We can try declaring HTTP_EVADER_OK and see which tests pass, but then we'd have to correlate that with the list of skipped tests if HTTP_EVADER_OK is not declared. Quite cumbersome.

So my suggestion is to add a way to check this. Run suricata-verify with an option to try tests with a skip condition anyway.

Something like:

run.py --test-skip HTTP_EVADER_OK

This would then only run those tests that have HTTP_EVADER_OK in their requires and would output something like:
===> http-evader-447: FAILED requires HTTP_EVADER_OK, so considering OK
===> http-evader-448: OK - is requires HTTP_EVADER_OK needed?
..
PASSED:  1368
FAILED:  0
SKIPPED: 149
SKIPPED OK: 1
SKIPPED FAIL: 1

This would then make it clear which of the tests needs to be updated.


Related issues

Related to Optimization #3172: Give only test count as outputClosedShivani BhardwajActions
Actions #1

Updated by Victor Julien about 2 years ago

  • Target version set to QA
Actions #2

Updated by Andreas Herz about 2 years ago

  • Assignee set to OISF Dev
  • Effort set to medium
  • Difficulty set to low
Actions #3

Updated by Shivani Bhardwaj about 2 years ago

  • Status changed from New to Assigned
  • Assignee changed from OISF Dev to Shivani Bhardwaj
Actions #4

Updated by Peter Manev about 2 years ago

off note - i just saw a small miss spell

 http-evader-448: OK - is requires ...

"is requires" should probably be "required".

(newbie :) ) Question - do we have a way to list what can be declared to be skipped ? Or how to list multiples tests sequences to be skipped?

Actions #5

Updated by Jason Ish about 2 years ago

Related: You can tell suricata-verify what tests to run as well, for example:

.../run.py dns

will only run tests with "dns" in the name.

.../run.py dns http

will run tests with "dns" OR "http" in the name.

Actions #6

Updated by Shivani Bhardwaj about 2 years ago

  • Status changed from Assigned to Feedback
Actions #7

Updated by Shivani Bhardwaj about 2 years ago

  • Status changed from Feedback to Assigned
Actions #8

Updated by Shivani Bhardwaj almost 2 years ago

Actions #9

Updated by Shivani Bhardwaj over 1 year ago

  • Status changed from Assigned to Feedback
Actions #10

Updated by Shivani Bhardwaj over 1 year ago

  • Status changed from Feedback to Assigned
Actions #11

Updated by Shivani Bhardwaj 12 months ago

  • Assignee changed from Shivani Bhardwaj to Community Ticket
Actions #12

Updated by Shivani Bhardwaj 12 months ago

  • Status changed from Assigned to New
  • Effort deleted (medium)
  • Difficulty deleted (low)
  • Label Outreachy, Python added
Actions #13

Updated by Dingani Muzimba 11 months ago

  • Assignee changed from Community Ticket to Dingani Muzimba
Actions #14

Updated by Jason Ish 28 days ago

  • Assignee changed from Dingani Muzimba to Jason Ish
  • Label deleted (Outreachy)
Actions

Also available in: Atom PDF